pjlinkv2 adapter added

[oberstel]

[Apollon77]

@oberstel Please check the checker comments above and ping again here when fixed

[Apollon77]

PS: beside travis it is better to add github testing

[oberstel]

fixed all issues reported by the adapter checker please re-check

[oberstel]

Adapter Check reports „not on travis“, but that’s wrong :-( Pls take a look at: https://app.travis-ci.com/github/oberstel/ioBroker.pjlinkv2

Adapter Check reports „Bluefox not found…“, but that‘s wrong as well. Pls take a look at: https://www.npmjs.com/package/iobroker.pjlinkv2

[oberstel]

argh… ich habe doch alles gefixed. Was muss ich denn noch machen???

Grüße lob

Am 14.12.2021 um 16:21 schrieb Bluefox @.***>:

 Automated adapter checker

ioBroker.pjlinkv2

❗ [E003] Repository must have name ioBroker.adaptername, but now io"b"roker is in lowercase ❗ [E004] No adapter name found in URL: https://raw.githubusercontent.com/oberstel/iobroker.pjlinkv2/master ❗ [E020] Name of adapter in package.json must be lowercase and be equal to "iobroker.". Now is "undefined" ❗ [E019] Invalid repository URL: https://github.com/oberstel/ioBroker.pjlinkv2. Expected: git+https://github.com/oberstel/iobroker.pjlinkv2.git ❗ [E103] common.name in io-package.json must be equal to "". Now is pjlinkv2 ❗ [E200] Not found on npm. Please publish ❗ [E300] Not found on travis. Please setup travis 👀 [W400] Cannot find "" in latest repository ioBroker.PJLinkV2

❗ [E005] Adapter name must be lowercase ❗ [E006] Invalid characters found in adapter name "PJLinkV2". Only lowercase chars, digits, "-" and "_" are allowed ❗ [E019] Invalid repository URL: https://github.com/oberstel/ioBroker.pjlinkv2. Expected: git+https://github.com/oberstel/ioBroker.PJLinkV2.git ❗ [E200] Not found on npm. Please publish ❗ [E300] Not found on travis. Please setup travis 👀 [W400] Cannot find "PJLinkV2" in latest repository Add comment "RE-CHECK!" to start check anew

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[Apollon77]

hast du gelesne was sa steht? Alsodas Repohat im Namen nach "ioBroker" grossbuchstabel,was nicht erlaubt ist.Ebenso der Adapternae an sich ...bitte alles Kleinbuchstaben

Dann sollte eine Versionnmal auf NPM landen :-)vorher geht es nicht im Repo - vllt ist das auch nur wegen der groß/kleinschreibung

Travis kann false positive sein ... alles ok. AM beste ist eh GitHub actions zu nutzen.

[oberstel]

so, alle adapter-check findings sind jetzt bearbeitet. Bitte den Adapter in das Repo aufnehmen.

[Apollon77]

Hi, sorry for the delay. here are the review comments(ignore the auto checker above ,... he is confused by the history of the PR):

• https://github.com/ioBroker/ioBroker.repositories/pull/1542/files#diff-2f081148e7c1e967d95d62cf221b95076ecfce50a93bb9f82bc96d0ddb2d05a1R1365 ... please adjust link to use guthubraw/CDN host like link in line above
• Please re-add adapter testing to the test-and-release-workflow ... only package testing is included and no test:integration or such
• Please remove https://github.com/oberstel/ioBroker.pjlinkv2/blob/master/admin/custom_m.html if not used
• It seems to me that the config options you set via admin and the ones in io-package native section do not match ... the native section should contain the default values for the fields you set in admin. Please sync
• Should the password not better be stored encrypted? Please see readme in repo and best practices for details or ask please
• maybe add amogline here with an info why the adapter runs but nothing works? :-) https://github.com/oberstel/ioBroker.pjlinkv2/blob/master/main.js#L55
• Button is normally write only (like a trigger) ... if you want on/off then the correct role is "switch", e.g. https://github.com/oberstel/ioBroker.pjlinkv2/blob/master/main.js#L77 (and more) Please in general check the roles relevant in https://github.com/ioBroker/ioBroker/blob/master/doc/STATE_ROLES.md - e.g. also isPower would maybe better an "indicator"? And strings can not be indicator but better "state" ...
• Please store all Timeouts and Intervals in a variable and execute clearInterval in te unload method. after you call the unload callback your code needs to be stopped! (e.g. https://github.com/oberstel/ioBroker.pjlinkv2/blob/master/main.js#L291)
• Please only execute a contron in https://github.com/oberstel/ioBroker.pjlinkv2/blob/master/main.js#L393 when state.ack is set to false!
• How long a conplete poll cycle needs currently? If longer then 500ms then you need to make sure to remember when unload was called and add checks after each "communicatzion" because very short after you called the unload callback the database object is destroyed and then you would get a lot of error sif still code is executed.

Please check and adjust.

PS: For translations you can use the iobroker translation tools ... see readme of repo

[Apollon77]

@oberstel ready for re-review or not yet?

[oberstel]

Need some time to look into your feedback…

Am 07.01.2022 um 14:40 schrieb Ingo Fischer @.***>:

 @oberstel ready for re-review or not yet?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

[Apollon77]

kk, just poke when ready

[ldittmar81]

Please close https://github.com/ioBroker/AdapterRequests/issues/526 after review

[Apollon77]

@oberstel any update?

[GermanBluefox]

Automated adapter checker

ioBroker.pjlinkv2

• [ ] :heavy_exclamation_mark: [E003] Repository must have name ioBroker.adaptername, but now io"b"roker is in lowercase
• [ ] :heavy_exclamation_mark: [E004] No adapter name found in URL: https://github.com/oberstel/iobroker.pjlinkv2
• [ ] :heavy_exclamation_mark: [E020] Name of adapter in package.json must be lowercase and be equal to "iobroker.". Now is "iobroker.pjlinkv2"
• [ ] :heavy_exclamation_mark: [E103] "common.name" in io-package.json must be equal to "'". Now is pjlinkv2
• [ ] :heavy_exclamation_mark: [E200] Not found on npm. Please publish
• [ ] :heavy_exclamation_mark: [E512] "admin/jsonCustom.json5" not found, but custom support is declared
• [ ] :heavy_exclamation_mark: [E605] No actual year found in copyright. Please add "Copyright (c) 2022 oberstel [email protected]" at the end of README.md
• [ ] :heavy_exclamation_mark: [E701] No actual year found in LICENSE. Please add "Copyright (c) 2022 oberstel [email protected]" at the start of LICENSE
• [ ] :eyes: [W171] "common.title" is deprecated in io-package.json
• [ ] :eyes: [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W170] "common.keywords" should not contain "iobroker, adapter, smart home" io-package.json
• [ ] :eyes: [W156] Adapter should support admin 5 UI (jsonConfig)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W400] Cannot find "" in latest repository
• [ ] :eyes: [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

ioBroker.PJLinkV2

• [ ] :heavy_exclamation_mark: [E005] Adapter name must be lowercase
• [ ] :heavy_exclamation_mark: [E006] Invalid characters found in adapter name "PJLinkV2". Only lowercase chars, digits, "-" and "_" are allowed
• [ ] :heavy_exclamation_mark: [E200] Not found on npm. Please publish
• [ ] :heavy_exclamation_mark: [E512] "admin/jsonCustom.json5" not found, but custom support is declared
• [ ] :heavy_exclamation_mark: [E605] No actual year found in copyright. Please add "Copyright (c) 2022 oberstel [email protected]" at the end of README.md
• [ ] :heavy_exclamation_mark: [E701] No actual year found in LICENSE. Please add "Copyright (c) 2022 oberstel [email protected]" at the start of LICENSE
• [ ] :eyes: [W171] "common.title" is deprecated in io-package.json
• [ ] :eyes: [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W170] "common.keywords" should not contain "iobroker, adapter, smart home" io-package.json
• [ ] :eyes: [W156] Adapter should support admin 5 UI (jsonConfig)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W400] Cannot find "PJLinkV2" in latest repository
• [ ] :eyes: [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

ioBroker.pjlinkv2

• [ ] :heavy_exclamation_mark: [E512] "admin/jsonCustom.json5" not found, but custom support is declared
• [ ] :heavy_exclamation_mark: [E605] No actual year found in copyright. Please add "Copyright (c) 2022 oberstel [email protected]" at the end of README.md
• [ ] :heavy_exclamation_mark: [E701] No actual year found in LICENSE. Please add "Copyright (c) 2022 oberstel [email protected]" at the start of LICENSE
• [ ] :eyes: [W171] "common.title" is deprecated in io-package.json
• [ ] :eyes: [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W170] "common.keywords" should not contain "iobroker, adapter, smart home" io-package.json
• [ ] :eyes: [W156] Adapter should support admin 5 UI (jsonConfig)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
• [ ] :eyes: [W400] Cannot find "pjlinkv2" in latest repository
• [ ] :eyes: [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

Add comment "RE-CHECK!" to start check anew

[Apollon77]

@oberstel How we should continue? Can we help somehow? Should we do a PR with relevant changes? But that would still require you to verify and test and release it afterwards because the changes can only be done "blind".

[Bannsaenger]

Vorab: Es ist mir bewusst, dass bereits ein PJLink Adapter zur Aufnahme in das beta repository existiert.

Da ich aktuell für ein Projekt von mir einen solchen Adapter benötige, habe ich selbst einen entwickelt. Dieser basiert auf dem bestehenden node Packet node/pjlink Github Link: https://github.com/sy1vain/node-pjlink

Der Plan wäre, das bestende Paket, das auch z.B. für ein Node-RED addon verwendet wird, auf Unterstützung für Class 2 incl. Gerätesuche zu erweitern und danach den Adapter auch entsprechend für Class 2 zu erweitern.

Bitte testet mal den Adapter. Er läuft bei mir gegen einen Optoma Projektor. Ebenfalls getestet ist er mit dem Simulator von der PJLink Homepage.

Wenn gewünscht kann ich auch gerne englisch schreiben.

[mcm1957]

@Apollon77 This PR is a little bit confusing from my point of view. It contains an update for sources-dist-STABLE.json. But an adapter pjlinkv2 is NOT at latest until now.

So what? I think this PR should be closed and if still intereste to add an ioBroker.pjlinkv2 adapter, a clean PR for latest repository should be created.

[mcm1957]

No feedback at all. Closing this PR or now.

Please open a new PR to add the adapter to latest if desired.