ioBroker.js-controller icon indicating copy to clipboard operation
ioBroker.js-controller copied to clipboard

Published 20 hours ago • verified publisher icon ioBroker

Added new category for notifications: `blocked`

Open GermanBluefox opened this issue 2 years ago • 8 comments

GermanBluefox avatar Jul 18 '22 09:07 GermanBluefox

blacklisted

I have nothing against blacklisted. It was just first attempt.

GermanBluefox avatar Jul 20 '22 13:07 GermanBluefox

Personally I am not a fan about introducing a new property blacklisted after the discussions in the last few years about this topic. I am also aware, that it might not be as easy finding an alternative and that blacklist is a common terminology, so I will agree with majority on the terminology here. However, just wanted to point this out as we already had discussions and e. g. in the Multihost migration mechanism we explicitly used Primary/Secondary instead of Master/Slave. Alternatives could be blocklist or denylist, where I would prefer the first one here.

foxriver76 avatar Aug 16 '22 09:08 foxriver76

Personally I am not a fan about introducing a new property blacklisted after the discussions in the last few years about this topic. I am also aware, that it might not be as easy finding an alternative and that blacklist is a common terminology, so I will agree with majority on the terminology here. However, just wanted to point this out as we already had discussions and e. g. in the Multihost migration mechanism we explicitly used Primary/Secondary instead of Master/Slave. Alternatives could be blocklist or denylist, where I would prefer the first one here.

Then blocked ?

GermanBluefox avatar Aug 30 '22 10:08 GermanBluefox

maybe blocklist not sure what the others think here @Apollon77 @AlCalzone

foxriver76 avatar Aug 30 '22 10:08 foxriver76

BlockedVersions? ForbiddenVersions?

So yes blocked also ok for me

Apollon77 avatar Aug 30 '22 10:08 Apollon77

See my initial comment :)

"blocked" isn't self explanatory IMO.

I'm fine with blocklisted

AlCalzone avatar Aug 30 '22 10:08 AlCalzone

Then lets do blocklisted ...

Apollon77 avatar Aug 30 '22 21:08 Apollon77

and how we name it in io-package? Do we stay with "blockedVersions" as property in common?

Apollon77 avatar Sep 07 '22 22:09 Apollon77

? @foxriver76 @Apollon77

GermanBluefox avatar Oct 24 '22 06:10 GermanBluefox

blockedVersions would be fine for me regarding io-pack and name in PR is also fine so LGTM if someone wants to optimize the messages go for it and do we want to add uk lang for new stuff or one translation PR for everything?

foxriver76 avatar Oct 24 '22 06:10 foxriver76

I added UK translation and changed type to blockedVersions. But honestly I already forgot for what it was purposed :(

GermanBluefox avatar Nov 29 '22 12:11 GermanBluefox

But honestly I already forgot for what it was purposed :(

AFAIK: We want to add the possibility to prevent specific adapter versions from starting. And to inform the user, we want this new category for the notification system

foxriver76 avatar Nov 29 '22 12:11 foxriver76

Exactly. js-controller should prevent all version in "BlockedVersions" from starting. Same as Admin should block already now

Apollon77 avatar Nov 29 '22 21:11 Apollon77

Exactly. js-controller should prevent all version in "BlockedVersions" from starting. Same as Admin should block already now

And... LGTM?

GermanBluefox avatar Dec 01 '22 21:12 GermanBluefox