ioBroker.js-controller icon indicating copy to clipboard operation
ioBroker.js-controller copied to clipboard

Published 20 hours ago • verified publisher icon ioBroker

Enforce using https during setup when accessing Github API

Open jpawlowski opened this issue 2 years ago • 4 comments

jpawlowski avatar Jun 19 '22 14:06 jpawlowski

Yes, please fix the formatting ...

Apollon77 avatar Jun 19 '22 22:06 Apollon77

To me it seems this repository comes with some presets for the Prettier extension in VScode (.prettierignore and .prettierrc.json). There might be incompatibilities with the settings you put in .eslintrc.js, resulting in this failure.

If you want me to fix the formatting, I suggest that this gets sorted out in the first place? I didn't change the formatting intentionally but simply followed what is configured for this repo.

jpawlowski avatar Jun 20 '22 12:06 jpawlowski

There might be incompatibilities with the settings you put in .eslintrc.js, resulting in this failure.

There should be no, @AlCalzone is working with VSCode too and it is all fine. Have you actually installed the Prettier extension for the project? Else default configurations of your editor might be applied.

foxriver76 avatar Jun 20 '22 13:06 foxriver76

This happens when I check out this PR in VSCode (with Prettier extension installed) and auto-format: grafik

So yeah, it should work fine.

AlCalzone avatar Jun 20 '22 14:06 AlCalzone