ioBroker.js-controller icon indicating copy to clipboard operation
ioBroker.js-controller copied to clipboard

Check if changes in `os.networkInterfaces()` in node 18 affect us

Open AlCalzone opened this issue 2 years ago • 4 comments

<       family: 'IPv4',
---
>       family: 4,
14c14
<       family: 'IPv6',
---
>       family: 6,

AlCalzone avatar Apr 22 '22 20:04 AlCalzone

The numbers are node.js 18, the strings are 16: https://github.com/nodejs/node/pull/41431#pullrequestreview-929717323

AlCalzone avatar Apr 22 '22 20:04 AlCalzone

Hm ... veeery super that someone noted it but then accepted it as if he would be the only one potentially affected :-(

Apollon77 avatar Apr 23 '22 17:04 Apollon77

A code check at least show that we do not use ".family" and also "IPv" as string is only used in a setting

Apollon77 avatar Apr 23 '22 17:04 Apollon77

We might need to update some deps though, basically everything that does mDNS

AlCalzone avatar Apr 23 '22 18:04 AlCalzone

I think this can be closed now, right?

AlCalzone avatar Aug 28 '22 14:08 AlCalzone

in which version the revert was now in finally?

Apollon77 avatar Aug 28 '22 19:08 Apollon77

https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#2022-06-16-version-1840-current-danielleadams 18.4.0

AlCalzone avatar Aug 29 '22 20:08 AlCalzone