ioBroker.javascript icon indicating copy to clipboard operation
ioBroker.javascript copied to clipboard

No Astro Functions prior to to 18h

Open Grothesk242 opened this issue 2 years ago • 7 comments

When sunset is earlier than 18h, the adapter does show 18h as the earliest time. There are no additional restrictions (e.g. Not Earlier than XY) set in the adapter.

Grothesk242 avatar Oct 30 '23 17:10 Grothesk242

not sure if it should be like it is now but if you are only interested in real values you can set the Not Earlier fields to something real early, like 15::00 for sunset

winnyschuster avatar Oct 30 '23 18:10 winnyschuster

This is the workaround that I use for the moment. But it's still a bug from my view, at least it's an unexpected behaviour.

Grothesk242 avatar Oct 30 '23 18:10 Grothesk242

its not a bug, these values are set intentionally in case fields are empty(== undefined). However, i fully agree that its an unexpected behaviour. At least fields should be filled with these default so the user knows they should'nt be left empty

winnyschuster avatar Oct 30 '23 19:10 winnyschuster

I would expect that in case of an empty field the real astro times would be considered.

Grothesk242 avatar Nov 02 '23 17:11 Grothesk242

There are no additional restrictions (e.g. Not Earlier than XY) set in the adapter.

Please share your instance configuration - default is 18:00

Screenshot 2023-11-06 at 13 23 08

klein0r avatar Nov 06 '23 12:11 klein0r

https://github.com/ioBroker/ioBroker.javascript/blob/3130e4549da0d631d694d148aacbf147abbae0de/io-package.json#L297

Okay, this is the problem:

https://github.com/ioBroker/ioBroker.javascript/blob/3130e4549da0d631d694d148aacbf147abbae0de/admin/index_m.html#L238-L240

klein0r avatar Nov 06 '23 12:11 klein0r

I'd recommend to set these defaults to times that are during bright daylight to avoid this unexpected behaviour. Or make these default settings visible.

Grothesk242 avatar Nov 06 '23 14:11 Grothesk242