[bug]: license can't be confirmed
No existing issues.
- [x] There is no existing issue for my problem.
Describe the bug
Since Admin Version 7.7.19 (maybe earlier) the license for net-tools is no longer shown, so IT can't be accepted. This leads to the fact that Admin Looks for IT in the url found in licensInformation.link from io-package.json
When this field was introduced there where confusion about the correct Destination of the Link. After a discussion the conclusion was that IT has to Point to the Site where the license can be buyed. But now IT seems that IT has to Point to the legal Text.
To Reproduce
Install Admin 7.7.19 and try to Install net-tools Adapter 1.2.1 or Power.
Expected behavior
Clarify the meaning and function of this field. If the function of this field is to show the User a Link to the Site/Shop where He can buy the license, revert These Changes.
Screenshots & Logfiles
N/A
Adapter version
7.7.19
js-controller version
Not relevant
Node version
Not relevant
Operating system
Not relevant
Additional context
No response
I could reproduce the problem.
@Jey-Cee your web site does not allow CORS:
Yes but that does Not Matter, while this ist the Shop Site where the User can buy a license Key. But the Admin ist looking for the legal Text in this Link. As i already written this is new with Admin Version 7.7.19
Again: Whats is the meaning/function of this Link? When IT was introduced IT was sayed that IT has to Point to the Shop Site and Not to the legal Text.
When we introduced licenseInformation, we defined that the link should point to the page containing more detailed purchase information. The link to the license text is already defined by the license itself. It makes no sense to disregard/not support the link for free adapters—they're required to display the license text anyway—while simultaneously requiring paid adapters to include a separate link to the license text.
In my opinion, the relevant license should always be displayed, and the link should only be used in conjunction with other information (e.g., after the $ sign).
If the link within licenseInformation should / muist really point to the legal text it could be omitted totally as this functionality is implemented for free adapters anyway so it does not make any sense to add a linkt to the legal text (i.e. MIT, GPL; ...) here
Everything worked fine with earlier 7.x.x of admin. When / why was this changed? Looks like a bug for mee