ioBroker.admin icon indicating copy to clipboard operation
ioBroker.admin copied to clipboard

[enhancement]: Remove jsonConfig schema validation and move it to adapter-check

Open klein0r opened this issue 1 year ago • 2 comments

No existing issues.

  • [X] There is no existing issue for my request.

Related problems

The schema validation creates a lot of issues and warnings for end users. Should be removed from the admin adapter.

https://github.com/ioBroker/ioBroker.admin/blob/bc2c0d4c547bbc8b4daefa2b95cc42c1288adb23/packages/admin/src-backend/lib/web.js#L363-L408

Description

Should be checked by https://adapter-check.iobroker.in

Additional context

No response

klein0r avatar Apr 02 '24 12:04 klein0r

I disagree

Most developers do not regularly check their adapters before the release a new version, Due to many false positive situation this could not be listed as error either So this check will likely be ignored (like several others :-( )

I will consider adding the check to the repochecker but it conflicts with current implementation as a useful output cannot be concentrated into one line ouf output. And the checker is designed to return an array of messagelines wihich in turn are formatted by the cli, by website (iobroker.dev) or scripts at repository checker. So not sure if an usefull implmentation could be done in a simple way.

Currently this solution is working fine, so I do not see a big benefit to revert it. OIn addition if a user claims that something is not workiung, the jsonConfig error would be visible in log togetehr with the problem.

But of course - we can discuss everything...

mcm1957 avatar Apr 02 '24 13:04 mcm1957

Most developers do not regularly check their adapters before the release a new version

That is another problem - but (in my opinion) not a valid reason to face end users with cryptic warnings in their logs. If we raise a warning for everything which is not developed 100% correctly, we spam the logs with unnecessary information (like missing translations).

klein0r avatar Apr 02 '24 14:04 klein0r