ioBroker.admin icon indicating copy to clipboard operation
ioBroker.admin copied to clipboard

[bug]: No LICENSE information with older admin

Open mcm1957 opened this issue 1 year ago • 8 comments

No existing issues.

  • [X] There is no existing issue for my problem.

Describe the bug

Adapters SHELLY and NOT-TOOLS already migrated and use common.licenseInformation Those adapter do not display any license information with current stable admin (6.13.16)

image

To Reproduce

Install current stable admin (6.13.16) select lates repository see screenshot attached above

Expected behavior

Older admin should display license information as usual.

Screenshots & Logfiles

see description

Adapter version

6.13.16

js-controller version

5.0.19

Node version

v18.19.1

Operating system

raspian

Additional context

No response

mcm1957 avatar Feb 21 '24 14:02 mcm1957

Additional information

After updating admin to 6.14.1 still no license information is visible. 6.14.1 IS installed at the alignment of icons is no OK

image

mcm1957 avatar Feb 21 '24 14:02 mcm1957

OK next info:

Problem seesm to be the repository script https://repo.iobroker.live/sources-dist-latest.json

Does NOT contain a license or licenseInformation object (at least I die not find it - reading this big file is a little bit difficult)

mcm1957 avatar Feb 21 '24 14:02 mcm1957

the latest repo now seems to be built correctly. See e.g. shelly (licenseInfo correctly transformed into license, and vis-2 correctly has new and old attriubutes for now as it is non-free type)

foxriver76 avatar Feb 22 '24 07:02 foxriver76

Will have to check .json and source io-packages.json. Something still seems to be wrong.

  • shelly seems to be OK now
  • net-tools is still missing license text and $ indicator

image

admin 6.14.1 latest repository manual refreh triggered (search for updates button clicked)

mcm1957 avatar Feb 22 '24 07:02 mcm1957

not a repo issue with net-tools https://github.com/Jey-Cee/ioBroker.net-tools/issues/32

foxriver76 avatar Feb 22 '24 08:02 foxriver76

OK, and sorry - did not check this one. Thanks for Issue @net-tools

mcm1957 avatar Feb 22 '24 12:02 mcm1957

Additional question:

There was no correction commit at repo iobroker.repositories.

image

Where was the code fixed? Will the scripts at iobroker.repository be adapted or are they outdated? We should clearify whgich scripts are executed and where they are maintained. (O - its OT here, but consider this as a reminder to clearify with BF)

mcm1957 avatar Feb 22 '24 12:02 mcm1957

As mentioned in telegram, BF noticed later on, that the code in repositories is not the one executed as he first thought. So we could delete the stuff in repositories and add to readme that it is build on AWS instead. As far as I understood, it is not worth the effort currently to migrate it to GH, however, at least the full core team has now access to the code.

foxriver76 avatar Feb 22 '24 12:02 foxriver76

I think this should be fixed at repo level

foxriver76 avatar Mar 01 '24 07:03 foxriver76

Yes, feel free to close Otherwise I will test as soon as tesing PR has been released by Dominiy so that adapetrs with ne Information can be released

mcm1957 avatar Mar 01 '24 12:03 mcm1957

Problem seesm to be fixed after update of effeted adapters.

So we can close here

mcm1957 avatar Mar 06 '24 12:03 mcm1957