create-adapter icon indicating copy to clipboard operation
create-adapter copied to clipboard

Published 20 hours ago • verified publisher icon ioBroker

Nginx websocket fix

Open Avarios opened this issue 8 months ago • 1 comments

PR Checklist:

  • [ ] Provide a meaningful description to this PR or mention which issues this fixes.
  • [ ] Ensure the project builds with npm run build
  • [ ] Add tests for your change. This includes negative tests (i.e. inputs that need to fail) as well as baseline tests (i.e. how should the directory structure look like?).
  • [ ] Run the test suite with npm test
  • [ ] If there are baseline changes, review them and make a separate commit for them with the comment "accept baselines" if they are desired changes
  • [ ] If you added a required option, also add it to the template creation (.github/create_templates.ts)
  • [ ] Add a detailed migration description to docs/updates explaining what the user needs to do when manually updating an existing project
  • [ ] Add your changes to CHANGELOG.md (referencing the migration description and this PR or the issue you fixed)

Description:
In the current Version the dev container is spinning up a NGINX. IOBroker is using WebSockets for some Operations but with the current config, it fails to reach the websocket. With my change, the websocket connection is reachable again

Avarios avatar Mar 15 '25 12:03 Avarios

Had the same issue today, that the connection via nginx is not working. The websocket config was not complete.

The proposed solution works for me!

hacki11 avatar Apr 01 '25 20:04 hacki11

@Avarios do you mind working through the checklist? @AlCalzone are there any concerns from your side or can we bring it to master?

hacki11 avatar Apr 10 '25 13:04 hacki11

The changes look reasonable to me. If it is working, then the only thing left to do is to complete the PR checklist. Once this is done and all checks are green, I can merge this PR.

UncleSamSwiss avatar Apr 10 '25 13:04 UncleSamSwiss

Hi all, ill need two more weeks for this, it is not forgotten my time is very limited :D

Avarios avatar May 09 '25 15:05 Avarios

Hi all, ill need two more weeks for this, it is not forgotten my time is very limited :D

I have included your fix in #1137 where I have completed documentation an checklist already.

hacki11 avatar May 09 '25 15:05 hacki11

Hi all, ill need two more weeks for this, it is not forgotten my time is very limited :D

I have included your fix in #1137 where I have completed documentation an checklist already.

Cool, less work for me :D Thank you

Avarios avatar May 09 '25 15:05 Avarios

Ok, then I close here in favor of #1137

Apollon77 avatar Aug 31 '25 19:08 Apollon77