fireworks icon indicating copy to clipboard operation
fireworks copied to clipboard

Error using last PMMP relase for 1.12

Open enricoangelon opened this issue 5 years ago • 4 comments

[Server thread/CRITICAL]: Error: "Call to undefined method pocketmine\entity\DataPropertyManager::setItem()" (EXCEPTION) in "plugins/fireworks-master/src/xenialdan/fireworks/entity/FireworksRocket" at line 42

enricoangelon avatar Nov 28 '19 14:11 enricoangelon

There is an issue with pmmp since 3.9.3/3.9.2, where Mojang released 1.12 and pmmp changed SLOT_ITEM to something different. I have not yet figured out how the fireworks work in 1.12/1.13, and due to lack of debug symbols i can not retrieve the information i need via decompiling. I am hoping for anyone telling me how it works now tbh.

inxomnyaa avatar Nov 28 '19 16:11 inxomnyaa

Can you try out https://github.com/BlockHorizons/Fireworks (Poggit: https://poggit.pmmp.io/p/Firework) and tell me if it works? I currently got no access to a client

inxomnyaa avatar Nov 28 '19 17:11 inxomnyaa

(Sorry if it took me 5 days to reply but i rarely have time). Enabling Firework v0.0.1

THEN when i launch a firework

[19:38:53] [Server thread/CRITICAL]: Error: "Call to undefined method pocketmine\entity\DataPropertyManager::getItem()" (EXCEPTION) in "plugins/Fireworks.phar/src/BlockHorizons/Fireworks/entity/FireworksRocket" at line 72

enricoangelon avatar Dec 03 '19 19:12 enricoangelon

https://github.com/BlockHorizons/Fireworks/pull/5 If you'd like, you can download the phar from the pull request here: https://poggit.pmmp.io/ci/BlockHorizons/Fireworks/Fireworks/pr:3 (you might need to change build type dropdown to "pull request builds" to see the phar link) I will not further manage this repository after it being merged

inxomnyaa avatar Dec 12 '19 07:12 inxomnyaa