MagicWE icon indicating copy to clipboard operation
MagicWE copied to clipboard

Add new translations / Update old translations!

Open inxomnyaa opened this issue 4 years ago • 22 comments

📝 New Translations

I want to introduce new translations and update current ones. Interested in "Hacktoberfest"? Here you can get started!

Any language is appreciated!

❓ How to contribute

  • Create a fork
  • Edit or add the corresponding file in /resources/lang, based on the english translation found here
  • If you modify an already existing language file, please make sure to remove entries that do not exist on eng.ini, and add those that are missing
  • Create a pull request and reference this issue (referencing is optional)
  • Pull Requests will be merged shortly before 30th October to leave you some time to correct translations (This does not influence Hacktoberfest, they are still counted if not merged)

Thanks to everyone who contributes!

🗒 Notes & Guidelines

  • This is a Minecraft-related world editor, so some terms are special, i.e. "flood" has a similar meaning to the "Paint.exe paint bucket", and "Wand" is a region selection tool (See #64, there are several examples and explainations) (Please also check comments in this issue for some other special entries, like: https://github.com/thebigsmileXD/MagicWE2/issues/130#issuecomment-540112091)
  • The translation files must be named after the iso639-2 3-letter format (See https://www.loc.gov/standards/iso639-2/php/English_list.php)
  • The language.name key must be the "English Name of Language" entry from that website
  • Translation strings must be enclosed by " "
  • Readme may not be translated (too difficult to keep it updated)

❗ We had some discussions about some translation entries, so here is a heads-up on some things we have noticed:

  • Please make sure that {%0} is properly kept and do not contain spaces, those are text placeholders!
  • Make sure //togglewand and //toggledebug and similar entries with foregoing slashes are kept - those are commands
Translation key Explaination Reference
tool.debug.lore.2 Meta values are a Minecraft specific term https://github.com/thebigsmileXD/MagicWE2/pull/137#discussion_r331998383
ui.brush.options.flags Flags means "adding options" https://github.com/thebigsmileXD/MagicWE2/pull/150#discussion_r332669003
Biomes Biomes are a Minecraft specific term https://minecraft.gamepedia.com/Biome
Chunks Chunks are a Minecraft specific term https://minecraft.gamepedia.com/Chunk

💜 As always, enjoy Hacktoberfest!

Have fun and good luck with your 👕, Dan ❤

inxomnyaa avatar Oct 03 '19 21:10 inxomnyaa

Hi, I found the iso639-2 doesn't specify differences between Simplified Chinese and Traditional Chinese. Traditional Chinese is already taking the zho.ini file, should I use chi.ini or zh-s and rename zho.ini to zh-t.ini based on Wikipedia? 图片

dingyifei avatar Oct 04 '19 02:10 dingyifei

Turkish translation has come. #135

ooguz avatar Oct 04 '19 04:10 ooguz

You'll probably want to use chs then, at least that's how this project handles it: https://github.com/pmmp/PocketMine-Language/blob/master/README.md

Johnmacrocraft avatar Oct 04 '19 07:10 Johnmacrocraft

My bad.

Aericio avatar Oct 04 '19 07:10 Aericio

For the German translation the formal and informal "you" (du/Sie) is mixed. Which one do you prefer?

msdeibel avatar Oct 04 '19 09:10 msdeibel

Note: i changed the translations branch to be default to simplify it for the contributors, currently alot of people edited on master - please make sure to commit into translations!

Thanks so far!

inxomnyaa avatar Oct 05 '19 08:10 inxomnyaa

For the German translation the formal and informal "you" (du/Sie) is mixed. Which one do you prefer?

I updated german myself personally, though i will change them to be all lowercase, thanks for the reminder

inxomnyaa avatar Oct 05 '19 08:10 inxomnyaa

@dingyifei I think this covers it nicely: https://chinese.stackexchange.com/questions/6147/which-one-of-these-two-iso-639-2-code-refers-to-traditional-chinese-chi-or-zho, so chi.ini would be a good choice

inxomnyaa avatar Oct 05 '19 08:10 inxomnyaa

We had some discussions about some translation entries, so here is a heads-up on some things we have noticed:

  • Please make sure that {%0} is properly kept and do not contain spaces, those are places were strings are inserted
  • Make sure //togglewand and //toggledebug and similar entries with foregoing slashes are kept - those are commands
Translation key Explaination Reference
tool.debug.lore.2 Meta values are a Minecraft specific term https://github.com/thebigsmileXD/MagicWE2/pull/137#discussion_r331998383
ui.brush.options.flags Flags means "adding options" https://github.com/thebigsmileXD/MagicWE2/pull/150#discussion_r332669003
Biomes Biomes are a Minecraft specific term https://minecraft.gamepedia.com/Biome
Chunks Chunks are a Minecraft specific term https://minecraft.gamepedia.com/Chunk

inxomnyaa avatar Oct 09 '19 17:10 inxomnyaa

@thebigsmileXD Is the value of ui.flood.options.label.infoapply (line 92) correct ? Does not need to escape quotes like in command.brushname.set (line 36) ?

GEveloper avatar Oct 17 '19 15:10 GEveloper

@GEveloper it appears to work anyways

inxomnyaa avatar Oct 17 '19 23:10 inxomnyaa

It appears that Digitalocean finally sent email details about collecting the shirt!

Many thanks to everyone who contributed! Enjoy your shirt 👕 and coding!

inxomnyaa avatar Oct 25 '19 07:10 inxomnyaa

All pull requests are merged - the branch will be merged. If you have any suggestions or translation updates, feel free to open a PR

inxomnyaa avatar Dec 22 '19 09:12 inxomnyaa

New contributions are welcome! (#hacktoberfest2020)

inxomnyaa avatar Oct 02 '20 14:10 inxomnyaa

I'll update the Simplified Chinese translation, which branch should I use to create PR? (I assume the translation branch got merged into the master branch)

dingyifei avatar Oct 04 '20 17:10 dingyifei

latest branch would be best, PM4 or feature-flip-rotate

inxomnyaa avatar Oct 05 '20 07:10 inxomnyaa

Is the Portuguese one updated? If it isn't, I can contribute by updating it. @thebigsmileXD

silvaromero avatar Oct 07 '20 01:10 silvaromero

Hello, I can add Ukrainian translation. Should I?

nazmariam avatar Oct 12 '20 06:10 nazmariam

Hello, I can add Ukrainian translation. Should I?

go ahead, we don't have it yet @nazmariam

Is the Portuguese one updated? If it isn't, I can contribute by updating it. @thebigsmileXD

It looks completed, but proof readers are always good @romeroclaudino

inxomnyaa avatar Oct 12 '20 06:10 inxomnyaa

Feel free to contribute this year as well - new translation keys are being added very soon

Some changes to contributions: You shall natively speak the language you are translating to

inxomnyaa avatar Oct 11 '21 17:10 inxomnyaa

Hi! Which branch should we use as a reference for updated translations this year?

bebora avatar Oct 15 '21 14:10 bebora

Hi! Which branch should we use as a reference for updated translations this year?

palette-preview would be the most recent

inxomnyaa avatar Oct 18 '21 10:10 inxomnyaa