Tim OSullivan

Results 21 comments of Tim OSullivan

I find this so confusing as well, why is it not documented, its non obvious and this library is obvious popular enough (7k stars) to warrant proper documentation no? Am...

Yes please, a wider discussion on Circular imports and the strategies to solve them would be great as well. I.e. does LazyType only help the top level type annotation? Can...

In a way this is actually solved with the pydantic plugin, so strange that core library cannot do it

Behavior table: Let `T = TypeVar("T")` ... the extended table might like: field type | resolver return type | current behaviour | expected behaviour | current type | expected type...

A side note on #1891: there's actually a few missing cases that the previous PR misses. That PR only fixes the most simple case of the resolver returning `TypeVar("T")`. My...

Holding off on adding a RELEASE.md file as would like some discussion around this first: 1. Is it a good idea to use `StrawberryType.is_generic` for this? 2. Is `tests/schema/test_resolvers.py` the...

I have added some extra unit tests covering the Union[T, SomethingElse], Optional[T] and List[T] cases. > Maybe we can add a test for the schema, to check that the types...

playground for example in RELEASE.md: https://play.strawberry.rocks/?gist=715c09744893b8662b8468f29579ee90

#3674 would be amazing 🙏

> Apologies for the very late review! > > I've merged main into this PR and reviewed the code, looks good! I've left a minor note for the future, but...