InvokeAI icon indicating copy to clipboard operation
InvokeAI copied to clipboard

[bug]: InvokeAI/.venv/bin/invokeai-update line 5

Open TrickBit opened this issue 2 years ago • 3 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

OS

Linux

GPU

cuda

VRAM

No response

What version did you experience this issue on?

pre-nodes

What happened?

Selecting update from the menu fails with

Update InvokeAI Traceback (most recent call last): File "some path/InvokeAI/.venv/bin/invokeai-update", line 5, in from invokeai.frontend.config import invokeai_update ModuleNotFoundError: No module named 'invokeai.frontend.config'

InvokeAI/.venv/bin/invokeai-update line 5 from invokeai.frontend.config import invokeai_update should read: from invokeai.frontend.install import invokeai_update

Screenshots

No response

Additional context

Should I just offer a diff for this sort of thing rather than this in future?

Contact Details

[email protected]

TrickBit avatar Jun 16 '23 07:06 TrickBit

@TrickBit - Would definitely encourage you to propose a PR in the future if you think something needs to be changed. We may provide insight on upcoming changes that make it unnecessary, or discuss further etc., but so long as the PR isn't harder than starting an issue, it's a good place to get attention from the right folks to merge it in.

Specifically, in this case, I believe that the installer/start script is being fully updated to work w/ the new backend (and as of the branch you experienced this on, was part of what was "broken"). @lstein can confirm

hipsterusername avatar Jun 16 '23 13:06 hipsterusername

@hipsterusername - Being the troglodyte that I am, I'm not sure what is meant by "a PR" - sorry. Regarding what part was broken - well it could not actually load the "update" option from the menu because it was trying to import an non-existent python library : ie from invokeai.frontend.config import invokeai_update

This failed completely.

Changing the import line to : from invokeai.frontend.install import invokeai_update made it work. Am I missing something? I thought I'd made that clear in the bug report. I apologize if I've misunderstood. Cheers :)

TrickBit avatar Jun 18 '23 09:06 TrickBit

Ah! A PR is just a proposed code change in GitHub (acronym for a “pull request”) that would be made to the repo. All is clear :)

hipsterusername avatar Jun 18 '23 14:06 hipsterusername