InvokeAI icon indicating copy to clipboard operation
InvokeAI copied to clipboard

Published 20 hours ago • verified publisher icon invoke-ai

Binary installer workflow

Open mauwii opened this issue 3 years ago • 6 comments

DO NOT MERGE YET

mauwii avatar Dec 05 '22 12:12 mauwii

BTW: It would be hard to bring this workflow into a more useable form while windows is failing 😅

And since I can succesfully install the conda env on a windows runner I don't think the requirement creation is failing due to the fact that the windows runners use windows-2022

mauwii avatar Dec 06 '22 09:12 mauwii

@tildebyte what's the reason for the pinned GFPGAN Verison? Would id be feasable to unpin it for windows (or pin another version) as I did now, which made the workflow work?

@tildebyte @lstein So how to proceed with this Workflow's triggers? Maybe make it trigger on a tag, have two tags to find out if --reuse-hashes should be included or not?

mauwii avatar Dec 06 '22 16:12 mauwii

what's the reason for the pinned GFPGAN Verison?

IDK, You'd have to ask @lstein

tildebyte avatar Dec 07 '22 00:12 tildebyte

what's the reason for the pinned GFPGAN Verison?

IDK, You'd have to ask @lstein

The pinned GFPGAN version is the wrong workaround for a problem some windows users encountered. The symptom was that basicsr 1.4.2 failed to install. The incorrect solution was to pin a customized version of GFPGAN in which its setup had been doctored to import basicsr 1.4.1. The correct solution (discovered today!) is to enable Long Paths in the Windows registry. Apparently 1.4.2 has a file with a long pathname, while 1.4.1 doesn't.

I've unpinned GFPGAN in the latest iteration of the unified directory installer. That can be done here too.

lstein avatar Dec 09 '22 03:12 lstein

@mauwii I should probably put the binary installer into a usable state such that it installs into the invokeai directory rather than into the repo. Are there other issues that need to be addressed before this PR is merged?

lstein avatar Dec 12 '22 04:12 lstein

@lstein: Yes, there is a lot of discussion open, for example:

  • when should this workflow run (obviously not on every PR)
  • when should it include --reuse-hashes
  • where to puth the created zip files:
    • for the moment they're attached to the workrun run itself
    • should they push to the repo
    • should they add the attachments to the release
    • ...

So the DO NOT MERGE YET headline is serious imho, so will convert this PR to draft to make it more obvoius

mauwii avatar Dec 12 '22 09:12 mauwii

I guess this one is not relevant anymore

mauwii avatar Jan 04 '23 00:01 mauwii