InvokeAI icon indicating copy to clipboard operation
InvokeAI copied to clipboard

[bug]: Inpainting, unable to paint on touch devices

Open MarcusLlewellyn opened this issue 2 years ago • 3 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

OS

Windows

GPU

cuda

VRAM

24GB

What happened?

When using the inpainting feature of the web UI, I am unable to draw the mask on a touch screen. It does register a finger tap and draw a circle the size of the brush. But dragging a finger does not result in a paint stroke.

Screenshots

Screenshot_20221030-130711

Additional context

I understand that mobile support is sort of on the back burner at the moment, but right now the web UI is pretty usable on tablets/chromebooks with touch screens. I tested this on the latest stable releases of Firefox and Chrome with identical results.

Contact Details

marcus.llewellyn#2923

MarcusLlewellyn avatar Oct 30 '22 18:10 MarcusLlewellyn

Shouldn't be a difficult addition, just need to think about edge cases a bit. I have an iPad to test it on so that makes it easier too.

psychedelicious avatar Oct 31 '22 13:10 psychedelicious

Submitted this PR If there's any specific edge cases to test, please let me know.

mikedg1 avatar Nov 15 '22 11:11 mikedg1

Submitted this PR If there's any specific edge cases to test, please let me know.

Link is not working anymore, and i don't have an installed dev version. Not sure how its implemented right now. Is it simple dragging? Double-tap then drag or tap and hold then drag might be good option. Or maybe a button to stop drawing. Up to you, ofc, just a reminder that on mobile devices (if thats eventually planned) you also need to scroll the page, and maybe drawing on a simple drag, will make scrolling troublesome. Especially if image is a vertical rectangle, and fills the whole screen:)

Btw right now its possible to use on mobile devices with small code adjustments, and unpinned side panels. A little bit tricky, but somehow works.

Melodeiro avatar Nov 29 '22 01:11 Melodeiro