ui
ui copied to clipboard
invoiceninja
No Update Notification After Upgrading to 5.10.x
In InvoiceNinja 5.8.x and below, I had an update notification in the form of a blue triangle in the bottom left of the screen where the Info button is. In the React UI, this is now gone, and there's no indication of a later version being available.
In the iOS app, the update notification is still there and, when tapped, correctly displays the current version I'm on (5.10.16) and the newest version available (5.10.20), as shown below:
Further, the React UI now just shows v Latest Build, but it's not actually the latest version since I'm 4 versions behind:
For more information, see the ongoing thread here on the InvoiceNinja forums: https://forum.invoiceninja.com/t/new-updates-is-not-displayed-in-the-new-ui/16372
The react UI is built from the develop channel, you'll want to use the Health check to see the API version as that will contain the reference you are more familiar with v5.10.xxxx
We'll bring in the notification triangle to the UI.
you'll want to use the Health check to see the API version as that will contain the reference you are more familiar with
Gotcha, I understand that. But something still doesn't seem right if the React UI Info window is displaying "v Latest Build", because the version of the React UI that came with 5.10.16 (that I'm currently running) is not the latest build, is it?
It went from displaying the actual version (in API version 5.10.13):
To displaying "Latest Build" (in API version 5.10.16):
If 5.10.16's version of the React UI isn't in fact the latest React UI build, it feels odd that it displays "Latest Build", and that seems like a bug. But, if the version of the React UI hasn't changed in the latest version of InvoiceNinja (5.10.20), then this is correct.
The react tag has never been correct. Previously the react release tag referred to the last "tagged" release of the UI, but this was incorrect.
Our build pipeline works like this:
When we tag a release of the API, ie v5.10.20 the build pipeline packages up the latest version of the develop branch of the React UI. That is why we changed the description to v latest build and inserted the build date.
The react tag has never been correct. Previously the react release tag referred to the last "tagged" release of the UI, but this was incorrect.
Our build pipeline works like this:
When we tag a release of the API, ie v5.10.20 the build pipeline packages up the latest version of the develop branch of the React UI. That is why we changed the description to v latest build and inserted the build date.
Thanks for the clarification about the pipeline. But regarding this behavior, displaying v Latest Build doesn't brings any value. It's always v Latest Build no matter what the real version number is.
If the pipeline doesn't allow you to retrieve the real version number in order to display it. It might be preferable not to display it at all, and to only keep the release date.
@gaetan-hexadog the react version never has a version in this context. Its version is tightly coupled to the API release, so that should be used as the reference for the React Version.
@turbo124 that's why I think it might be preferable not to display it at all, and to only keep the release date.
Because there is no value to always display v Latest Build (no matter what version we are trying to display) if it's not changing and if we can't compare it with any available version, ...
@turbo124 Because there is no value to always display
v Latest Build(no matter what version we are trying to display) if it's not changing and if we can't compare it with any available version, ...
I agree. Otherwise, it's just confusing checking the status and seeing "v Latest Build", thinking "oh, I'm up to date", when really, I'm not up to date at all, and there's no indication here that this v Latest Build text is related to React. At first glance, seeing this makes me think I'm up to date, when in fact I'm 8 versions behind:
That is why we also append the date of the build itself to this particular line.
This was closed, but I have a feeling this only changed the version text in the About window, not the original issue of no blue update notification triangle appearing in the lower left to alert when a new version is available. I'm on 5.10.26 and the version displayed in the About window looks correct now, but I still don't see a notification icon telling me 5.10.27 is available, so I have a feeling the original issue here might have been missed.
This was originally discussed on the forums here: https://forum.invoiceninja.com/t/new-updates-is-not-displayed-in-the-new-ui/16372
@link470 can you add a new issue for that, i'll tag it into the backlog
This is the issue. If you read the first post in this, you'll see it describes the exact same thing. But I'll make another issue with the same text if you wish.
EDIT: Actually, I see I can edit the title. I'll modify this one so it's just talking about the version being displayed in the About window (the issue that was fixed).
Actually, I see I can edit the title. I'll modify this one so it's just talking about the version being displayed in the About window (the issue that was fixed).
On second thought, nevermind. I'm sticking with my original thought of this being the issue that needs to be fixed still. This should be reopened, and THIS issue (the one I believe was actually fixed here) should be closed as fixed. The original issue of the update notification not appearing, as described in the first post here, is still a problem, and this should be reopened.
Can this be re-opened per my message above? I believe the one I linked can be closed as well.
@turbo124 Just a reminder that this one should be re-opened as the original issue was never fixed. See my post 2 above this one. Thanks!
@Civolilah this item is to presnet an upgrade icon notification in place of the (i) button
The logic here is if
https://pdf.invoicing.co/api/version != current version - show the upgrade icon
i also intressted to get the update Notifcation Icon back in React app....
Forum Post https://forum.invoiceninja.com/t/new-updates-is-not-displayed-in-the-new-ui/16372 by AngryWarrior
the update Nofication Icon ist vissible in FLutter ap but not in React App
There are recent reports of this issue in the support forum
https://forum.invoiceninja.com/t/new-updates-is-not-displayed-in-the-new-ui/16372/60?u=hillel
