ui icon indicating copy to clipboard operation
ui copied to clipboard

Dead link

Open LarsK1 opened this issue 9 months ago • 15 comments

When I try to purchase a license in the React UI - nothing happens. The button has no link. image

LarsK1 avatar May 06 '24 14:05 LarsK1

Hi, can you please share your environment with us and version?

I've tested in latest version and link seems to be working fine.

beganovich avatar May 08 '24 04:05 beganovich

Hi, it's selfhosted v14.04.2024.1.

LarsK1 avatar May 08 '24 06:05 LarsK1

There's also no a tag in the html image

LarsK1 avatar May 08 '24 06:05 LarsK1

@Civolilah can you replicate?

beganovich avatar May 08 '24 15:05 beganovich

@Civolilah can you replicate?

@beganovich It works fine for me as well. The link for this element is actually pulled from the VITE_WHITELABEL_INVOICE_URL environment variable, so missing the link in the .env file can cause this issue. @LarsK1, can you please confirm whether your .env file is populated with the correct value for the VITE_WHITELABEL_INVOICE_URL variable?

Civolilah avatar May 08 '24 15:05 Civolilah

@Civolilah no, there's no such variable in there. There also no such one in the .env.example.

To what value should I set it?

LarsK1 avatar May 08 '24 15:05 LarsK1

@Civolilah no, there's no such variable in there. There also no such one in the .env.example.

To what value should I set it?

@LarsK1 The variable was probably added to the .env.example file later, which is why you're missing it. Please ensure that you have

VITE_WHITELABEL_INVOICE_URL=https://app.invoiceninja.com/buy_now/?account_key=AsFmBAeLXF0IKf7tmi0eiyZfmWW9hxMT&product_id=3

in the .env file, and it will work for you. Thanks!

Civolilah avatar May 08 '24 15:05 Civolilah

@Civolilah just added it, and also run php artisan optimize. Still no luck

LarsK1 avatar May 08 '24 15:05 LarsK1

The variable doesn't exist here as well: https://github.com/invoiceninja/invoiceninja/blob/v5-develop/.env.example

LarsK1 avatar May 08 '24 15:05 LarsK1

@LarsK1 Ah, there seems to be a slight misunderstanding. The variable needs to be added to the React/frontend project. Here is the current .env.example file, which is the best reference: https://github.com/invoiceninja/ui/blob/main/.env.example. Thanks!

Civolilah avatar May 08 '24 15:05 Civolilah

@LarsK1 where do I find this file in a regular install?

LarsK1 avatar May 08 '24 15:05 LarsK1

You'll have to share with us how you get v5 working. Is it a Docker install, prebuilt ZIP or you did do everything yourself?

beganovich avatar May 08 '24 15:05 beganovich

It's the prebuilt zip

LarsK1 avatar May 08 '24 15:05 LarsK1

Thanks.

cc @turbo124, might be able to help us :)

beganovich avatar May 08 '24 15:05 beganovich

@Civolilah

i think i know the issue, the link has changed:

https://invoiceninja.invoicing.co/client/subscriptions/O5xe7Rwd7r/purchase

Can we update the build for this url please.

turbo124 avatar May 08 '24 23:05 turbo124

@Civolilah

i think i know the issue, the link has changed:

https://invoiceninja.invoicing.co/client/subscriptions/O5xe7Rwd7r/purchase

Can we update the build for this url please.

@turbo124 Sure thing, the PR for updating the URL has been created. (#1761)

Civolilah avatar May 14 '24 13:05 Civolilah

Hi @turbo124 @Civolilah @beganovich , the big still exists, even though the pr is merged?

LarsK1 avatar May 26 '24 17:05 LarsK1

@LarsK1 we are looking into it, it is in the backlog again.

turbo124 avatar May 26 '24 20:05 turbo124