ui
ui copied to clipboard
invoiceninja
[Bugfix] Fixes For Failing Tests
@beganovich @turbo124 After finishing the permissions adjustment, 98% of tests are fixed and working great. This PR addresses only a few tests that are not covered by the permissions adjustment. Currently, locally, when I run all tests after seeding the initial database, all of them pass, more than 190 in total. However, on GitHub Actions, all of them fail. I believe this is due to a slight environmental adjustment needed there.
From the current status of tests, it appears that the login functionality in the app is unavailable. None of the tests are even executing their intended actions, they all fail at the login stage.
Therefore, as I see the situation now, I believe that fixing the connection with the API and DB will resolve this issue. Additionally, we need to ensure that the VITE_ROUTER environment variable is set to "browser" but NOT "hash," and VITE_IS_TEST variable is set to "true".
If I can assist in making any of these fixes, please let me know.
I guess it should be a good idea to fix GitHub actions in this PR? Is that something you can have a look at at some point @turbo124?
I guess it should be a good idea to fix GitHub actions in this PR? Is that something you can have a look at at some point @turbo124?
I'm seeing green currently?
@beganovich @turbo124 David made a PR today to fix actions, added some .env variables, and set up some other small things, but for some reason it still does not work. Writing a comment just to be aligned. Once I'm done with some other tasks, I can take a look at the whole workflow and try to replicate why it does not work the same as locally if you do not resolve it before me.
@Civolilah is this still draft?
@beganovich Yes, David and I worked on fixing GitHub actions to ensure the tests work the same as locally. We encountered a small problem with the API port, but David managed to find a solution. Currently, it is up to me to identify the reasons for some other minor bugs, and once I resolve them and pass the GitHub actions tests as we do locally, it will be ready for review.
We had some more important tasks than this one, so I addressed it once those were completed. However, I will prioritize fixing this asap and will keep you informed.