admin-portal icon indicating copy to clipboard operation
admin-portal copied to clipboard

Google GMS in F-Droid build

Open licaon-kter opened this issue 3 years ago • 1 comments

Ref: https://gitlab.com/fdroid/fdroiddata/-/jobs/2830921707 for https://github.com/invoiceninja/admin-portal/releases/tag/v5.0.91

# gradle :app:dependencies --configuration releaseRuntimeClasspath
...
+--- project :smart_auth
|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.10 (*)
|    +--- com.google.android.gms:play-services-auth:20.1.0
|    |    +--- androidx.fragment:fragment:1.0.0 -> 1.3.4 (*)
|    |    +--- androidx.loader:loader:1.0.0 (*)
|    |    +--- com.google.android.gms:play-services-auth-api-phone:18.0.1
|    |    |    +--- com.google.android.gms:play-services-base:18.0.1
|    |    |    |    +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
|    |    |    |    +--- androidx.core:core:1.2.0 -> 1.8.0 (*)
|    |    |    |    +--- androidx.fragment:fragment:1.0.0 -> 1.3.4 (*)
|    |    |    |    +--- com.google.android.gms:play-services-basement:18.0.0
|    |    |    |    |    +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
|    |    |    |    |    +--- androidx.core:core:1.2.0 -> 1.8.0 (*)
|    |    |    |    |    \--- androidx.fragment:fragment:1.0.0 -> 1.3.4 (*)
|    |    |    |    \--- com.google.android.gms:play-services-tasks:18.0.1
|    |    |    |         \--- com.google.android.gms:play-services-basement:18.0.0 (*)
|    |    |    +--- com.google.android.gms:play-services-basement:18.0.0 (*)
|    |    |    \--- com.google.android.gms:play-services-tasks:18.0.1 (*)
|    |    +--- com.google.android.gms:play-services-auth-base:18.0.1
|    |    |    +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
|    |    |    +--- com.google.android.gms:play-services-base:18.0.1 (*)
|    |    |    +--- com.google.android.gms:play-services-basement:18.0.0 (*)
|    |    |    \--- com.google.android.gms:play-services-tasks:18.0.1 (*)
|    |    +--- com.google.android.gms:play-services-base:18.0.1 (*)
|    |    +--- com.google.android.gms:play-services-basement:18.0.0 (*)
|    |    \--- com.google.android.gms:play-services-tasks:18.0.1 (*)
|    +--- com.google.android.gms:play-services-auth-api-phone:18.0.1 (*)
|    \--- io.flutter:flutter_embedding_release:1.0.0-6ba2af10bb05c88a2731482cedf2cfd11cf5af0b (*)
...

licaon-kter avatar Aug 09 '22 08:08 licaon-kter

Thanks for letting us know, we'll look into it

hillelcoren avatar Aug 09 '22 09:08 hillelcoren

fyi https://gitlab.com/fdroid/fdroiddata/-/commit/a9b28f2192f963bbd7b4f818e0c594630f69cf6b

Do ping us when the fully FOSS version is ready for testing

licaon-kter avatar Aug 30 '22 07:08 licaon-kter

Will do, hope to have a fix for this included in the next release

hillelcoren avatar Aug 30 '22 09:08 hillelcoren

This should be corrected in the next release, please add this line to the F-Droid build script:

cp lib/ui/app/pinput.dart.foss lib/ui/app/pinput.dart

hillelcoren avatar Sep 01 '22 09:09 hillelcoren

Trying 531b88109e893b9a6a740cbc52a63c20587f3c08 fails https://gist.github.com/licaon-kter/59d34fd7b245d84e5626ab3e3c7d8d23 with Flutter 3.0.5

licaon-kter avatar Sep 01 '22 11:09 licaon-kter

It may help to change to Flutter 3.3.0

hillelcoren avatar Sep 01 '22 11:09 hillelcoren

Now what? :(

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:checkReleaseAarMetadata'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckAarMetadataWorkAction
   > The minCompileSdk (32) specified in a
     dependency's AAR metadata (META-INF/com/android/build/gradle/aar-metadata.properties)
     is greater than this module's compileSdkVersion (android-31).
     Dependency: androidx.webkit:webkit:1.5.0.
     AAR metadata file: /home/vagrant/.gradle/caches/transforms-3/77020d4b21701e99d4c7d19aabb96858/transformed/webkit-1.5.0/META-INF/com/android/build/gradle/aar-metadata.properties.

licaon-kter avatar Sep 01 '22 14:09 licaon-kter

I'm not sure, I suggest retrying when the next release is tagged

hillelcoren avatar Sep 01 '22 15:09 hillelcoren

A new release is available, please use the latest stable Flutter version (3.3.2)

hillelcoren avatar Sep 15 '22 15:09 hillelcoren

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:checkReleaseAarMetadata'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckAarMetadataWorkAction
   > The minCompileSdk (32) specified in a
     dependency's AAR metadata (META-INF/com/android/build/gradle/aar-metadata.properties)
     is greater than this module's compileSdkVersion (android-31).
     Dependency: androidx.webkit:webkit:1.5.0.
     AAR metadata file: /home/vagrant/.gradle/caches/transforms-3/77020d4b21701e99d4c7d19aabb96858/transformed/webkit-1.5.0/META-INF/com/android/build/gradle/aar-metadata.properties.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 8m 37s
Running Gradle task 'assembleRelease'...                          519.2s

┌─ Flutter Fix ──────────────────────────────────────────────────────┐
│ [!] Your project requires a higher compileSdkVersion.              │
│ Fix this issue by bumping the compileSdkVersion in                 │
│ /home/vagrant/build/com.invoiceninja.app/android/app/build.gradle: │
│ android {                                                          │
│   compileSdkVersion 32                                             │
│ }                                                                  │
└────────────────────────────────────────────────────────────────────┘
Gradle task assembleRelease failed with exit code 1

@hillelcoren

licaon-kter avatar Sep 16 '22 11:09 licaon-kter

I've checked in the suggested fix

hillelcoren avatar Sep 16 '22 12:09 hillelcoren

Thanks https://gitlab.com/fdroid/fdroiddata/-/commit/a1677a3f7f3f4279b57a95fa6e15649291fdd9f9

licaon-kter avatar Sep 16 '22 14:09 licaon-kter