admin-portal icon indicating copy to clipboard operation
admin-portal copied to clipboard

Published 20 hours ago • verified publisher icon invoiceninja

Support for password-managers

Open LarsK1 opened this issue 4 years ago • 3 comments

Hey there, is it possible to add the necessary html-fields to the login/registration-fields in a manner, that password managers are able to auto fill or save the common fields?

See her, which fields would be required: https://hiddedevries.nl/en/blog/2018-01-13-making-password-managers-play-ball-with-your-login-form

Thanks for your reply, Lars

LarsK1 avatar Sep 21 '21 18:09 LarsK1

Hi,

This should sort of already work, you may not see the option in the field but you should be able to fill the form by clicking the plugin icon in the toolbar.

hillelcoren avatar Sep 21 '21 19:09 hillelcoren

It does work, if you manually force the password-manager to fill the fields. For me it seems, it isn't recognized, because it's no just a single form but at least 2?

LarsK1 avatar Sep 22 '21 06:09 LarsK1

The app is built with Flutter, all apps (web/mobile/desktop) are compiled from one shard codebase.

We'll most likely need to wait for this to be corrected in the framework, here's one related issue but there are more: https://github.com/flutter/flutter/issues/81201

hillelcoren avatar Sep 22 '21 07:09 hillelcoren

The fix for this has landed and will be in the next stable Flutter release!

kevmoo avatar Aug 03 '23 21:08 kevmoo

If you have a chance please check if there's a difference with the latest release

hillelcoren avatar Oct 30 '23 21:10 hillelcoren

Hi @hillelcoren , the password and 2FA fields are now detected. The user field is still missing the autocomplete="username" field (currently it's autocomplete="").

But it's still not perfect, since it seems, that the html for the input fields is generated on the flow, so that the password managers can only fill one field at a time. Seems to be related to https://github.com/flutter/flutter/issues/66356. Do you use an autofill group?

LarsK1 avatar Oct 31 '23 06:10 LarsK1

@LarsK1 the inputs are lazy-loaded which can lead to some issues with password manager autofill (being tracked here). Is the issue that the fields are only partially autofilling? If so, which 3rd party password manager is this occurring for?

To fix your second issue re: autocomplete attribute, make sure you're wrapping your text fields in an AutofillGroup and make sure to pass the appropriate autofill hints to the text field. In your case, it would be autofillHints: [AutofillHints.username]. I tried this on my end and it's populating the correct autocomplete attribute for the input.

htoor3 avatar Oct 31 '23 17:10 htoor3

@htoor3 yes it's only filling the field I currently selected. If none is selected none is filled. The password manager used is Roboform.

For the rest @hillelcoren would you mind checking - I'm not really into Flutter 😞

LarsK1 avatar Nov 02 '23 05:11 LarsK1