invoice2data icon indicating copy to clipboard operation
invoice2data copied to clipboard

Fixed one test and used an env var for the google cloud bucket

Open EtienneBerube opened this issue 5 years ago • 2 comments

The bucket name will be given as an environment variable as the method to_text() is only given one argument when used in extract_data().

The fixed test was using the wrong file extension to compare the results. Therefore, the test would not pass.

EtienneBerube avatar Jul 03 '19 18:07 EtienneBerube

I don't think we want to remove the function argument altogether.

m3nu avatar Jul 11 '19 00:07 m3nu

Note token. I removed the "default" option of the Google Cloud bucket name as it needs to be changed anyway by a new user (now defaults to None). Now, it can either be an argument, or an environment variable (depends on application). Can now be in a docker.

EtienneBerube avatar Jul 15 '19 14:07 EtienneBerube