retry icon indicating copy to clipboard operation
retry copied to clipboard

Published 20 hours ago • verified publisher icon invl

Logging doesn't properly format message

Open AlonSh opened this issue 6 years ago • 2 comments

Hey, I pass a logbook.Logger instance to the logger variable of retry:

@retry(exceptions=ConnectionError, tries=MAX_RETRIES, delay=RETRY_TIMEOUT, logger=logger)

And the matching logline I get is:

[2018-05-10 09:36:57.321720] WARNING: vector.core.file_collection.es_utils: %s, retrying in %s seconds...

(The %s are not properly formated)

Can you fix that? thanks!

AlonSh avatar May 10 '18 09:05 AlonSh

Any news on that ? @AlonSh maybe a PR if you made the change on your side ?

cscetbon avatar Mar 25 '20 13:03 cscetbon

Any news on that ? @AlonSh maybe a PR if you made the change on your side ?

I think I've just kept using it that way, but I don't remember exactly and I do not have access to the relevant code anymore. It's not a difficult fix

AlonSh avatar Mar 25 '20 20:03 AlonSh