Jaivardhan Kumar comments

Results 195 comments of


                                            Jaivardhan Kumar

[release-4.10] Bug 2117351: fix helm readme bug

/approve

[release-4.10] Bug 2117351: fix helm readme bug

@debsmita1 can you pls put gif of the scenario tested on bot?

[release-4.10] Bug 2117351: fix helm readme bug

/retest

[release-4.10] Bug 2117351: fix helm readme bug

/label backport-risk-assessed

[release-4.10] Bug 2117351: fix helm readme bug

/retest

Add functionality to add kafka-sinks as subscriber, trigger and event-source sink target

Thanks @divyanshiGupta looks good, have added a comment PTAL. Overall looks great, I don't see a tooltip on hover on KafkaSink while dragging connector as shown for ksvc?

Add functionality to add kafka-sinks as subscriber, trigger and event-source sink target

Thanks, now kafkaSink node is not active on hover but functionality works as expected, and add trigger/subscription tooltip comes offscreen. ![kafkaSinkHover](https://user-images.githubusercontent.com/5129024/182870692-888360e8-3622-4813-8fbb-63176c8055f7.gif)

Add functionality to add kafka-sinks as subscriber, trigger and event-source sink target

Thanks @divyanshiGupta, have verified the changes and works as expected. /cc @sanketpathak

Add functionality to add kafka-sinks as subscriber, trigger and event-source sink target

/lgtm

[release-4.11] Bug 2116265: fix failed PipelineRun log texts color in light mode

/test e2e-gcp-console