Mateusz Gozdek

Results 418 comments of Mateusz Gozdek

While working on this, we should also decide on publisher, offer and SKU names for SIG image definitions. Currently image-builder use publisher `capz`, offer `capz-demo` and SKU `flatcar-stable-2905.2.3`. Seems SKU...

This is how images look like using Azure CLI with proposed schema: ```console $ az sig image-definition list-community -l westeurope --public-gallery-name capiMatTestWE2-3282f15c-906a-4c4b-b206-eb3c51adb5be -o table | grep -v capi-flatcar-stable HyperVGeneration Location...

Thanks for feedback @jepio, greatly appreciated. >The names are case-insensitive, so lower-case makes sense. Make sense, adopted. >RE: naming. How about grouping related information: flatcar-stable-capi-1.22.11-gen2. I agree on the need...

Notes from today's meeting: - We may still want to consider `-amd64` prefix for images so we would be consistent with `-arm64` and possibly other architectures in the future. -...

RE: vanilla Flatcar SIG images. As we have Flatcar VHD available as a blob object, we can simply do `az sig image-version create --os-vhd-storage-account --os-vhd-uri` to add it to the...

Based on the recent checks (https://github.com/flatcar-linux/Flatcar/issues/734#issuecomment-1181588540), I propose the following changes to the proposed schema: - Start with creating just V2 image definitions without `-gen2` prefix. If the need arise...

>Using the explicit -amd64 and -arm64 suffixes is nice. In the past we only had -arm64 suffixes and it's a mess in the code base and it's easy to overlook...

To summarize, I think things would look roughly like following: ```yaml galleries: - publicNamePrefix: flatcar publicGalleryName: flatcar-52089376-cc7d-456e-8541-3c634dd271a2 imageDefinitions: - name: flatcar-stable-amd64 publisher: flatcar offer: stable sku: flatcar-stable-amd64 versions: - 3227.2.1...

Implementation is super simple for this, but as part of the test suite, we could actually test scenarios where all controller mangers go down for example.

We should now actually update to 1.0.