stripe-firebase-extensions icon indicating copy to clipboard operation
stripe-firebase-extensions copied to clipboard

feat: add "feature" attribute to firestore product attribute

Open huynhtk80 opened this issue 1 year ago • 9 comments

createProductRecord will now also save feature attribute if it's not null. This was missing from the current function, which would be useful when creating pricing tables. "Feature" attribute is passed in the stripe webhook.

huynhtk80 avatar Nov 03 '23 19:11 huynhtk80

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 03 '23 19:11 CLAassistant

+1, need it in relase

boskiv avatar Nov 22 '23 09:11 boskiv

+1 on this. I need this feature right now for rendering the pricing table using the data in firebase but the features are missing. Please merge this PR if it's working properly. Thanks.

eddieespinal avatar Dec 29 '23 14:12 eddieespinal

Hi @huynhtk80, thanks for your PR. It seems good to me, but I noticed the workflows aren't running, could you please check and update your PR.

The issue is having features as part of the Stripe.Product interface, which requires updating strip package.

pr-Mais avatar Jan 01 '24 12:01 pr-Mais

@huynhtk80 Hey, do you have time to address the issue pointed out by @pr-Mais? I would love to see this PR in production. Thanks.

eddieespinal avatar Jan 30 '24 11:01 eddieespinal

@pr-Mais Sorry for the delay, I've been busy with a new job, but will take closer look.

huynhtk80 avatar Jan 31 '24 05:01 huynhtk80

@pr-Mais I've created a pull request to update the Stripe package to update the type. As a temporary measure I've created a custom interface that extends Stripe.Product Not sure if that's an acceptable solution at this moment.

huynhtk80 avatar Jan 31 '24 06:01 huynhtk80

Really need this. Cant really build price tables without showing features. And the option to build pricing tables from the dashboard does not seems to work with firebase.

o-glethorpe avatar Mar 26 '24 14:03 o-glethorpe

Any chance this is able to be merged? Looking forward to this feature being included!

RideLikeTheWind avatar May 13 '24 09:05 RideLikeTheWind