stripe-firebase-extensions icon indicating copy to clipboard operation
stripe-firebase-extensions copied to clipboard

Clarify ${params}

Open joshdance opened this issue 2 years ago • 2 comments

This is tricky because we only want this note to show if they are reading on Github and not in the Extensions > How this Extension Works tab, but thought I would suggest it.

I didn't realize these parameters would fill in with my specific project details when I saw them on Github.

joshdance avatar Oct 04 '22 20:10 joshdance

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: joshdance
:white_check_mark: dackers86
:x: jsteele-stripe
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 04 '22 20:10 CLAassistant

Hi @joshdance

Typically for Firebase Extensions, any documentation that requires a param field - would need to be added to the PRINSTALL.md.

Extensions.dev documentation is added through the PREINSTALL.md,

README and CONTRIBUTING documentation is mainly for Github.

is there a particularly section of the docs which is in the incorrect file?

dackers86 avatar Oct 08 '23 11:10 dackers86