spec icon indicating copy to clipboard operation
spec copied to clipboard

feat: support --update-goldens

Open trejdych opened this issue 2 years ago • 9 comments

hello, I have added support for --update-golden option. It works for --watch mode too, however, I had to filter some files from an observer.

I have added 'g' keyboard shortcut to toggling update goldens mode. CleanShot 2022-10-01 at 12 32 10

temporary I've pinned riverpod to 2.0.0-dev.3.

Closes #8

PS. It's my first contribution ever so sorry if I did something wrong.

trejdych avatar Oct 01 '22 08:10 trejdych

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 01 '22 08:10 CLAassistant

Same here, this needs to be synced with main

rrousselGit avatar Oct 07 '22 12:10 rrousselGit

It'd be great if you could write a test that uses --update-goldens

rrousselGit avatar Oct 07 '22 12:10 rrousselGit

Sure! I'll try to add something.

trejdych avatar Oct 07 '22 13:10 trejdych

Awesome. I'll wait for it then. Otherwise your PR looks great, thanks for your work!

rrousselGit avatar Oct 07 '22 13:10 rrousselGit

it's my pleasure

trejdych avatar Oct 07 '22 13:10 trejdych

@rrousselGit I've added one test. Let me know if it is enough.

if you don't mind, I would like to add tests for the --watch too (I could do it not only for --update-goldens). However I think it's much more complex topic. Have you thought about it?

trejdych avatar Oct 07 '22 16:10 trejdych

It's looking good

Watch mode is a bit tricky indeed. I haven't thought about it too much. I'm open to suggestions

rrousselGit avatar Oct 07 '22 16:10 rrousselGit

To be honest I don't have idea yet ;) but I’ll think about it

trejdych avatar Oct 07 '22 17:10 trejdych

Sorry for the delay. Thanks for this!

rrousselGit avatar Mar 08 '23 12:03 rrousselGit