spec icon indicating copy to clipboard operation
spec copied to clipboard
verified publisher icon invertase

fix(dart_test_adapter): use valid SDK executable for tests

Open mrverdant13 opened this issue 3 years ago • 2 comments

Details

Retrieve de default SDK executable by checking the available runnable files for both Dart and Flutter, keeping their priority order according to the environment, and filtering them as follows:

  • For Windows: Valid extensions are .exe and .bat.
  • For other platforms: Valid extensions are .sh and (no extension).

This filtering step is required since Dart and Flutter installation includes all possible executables (no matter the target platform) and the Process.start does not validate if they are actually runnable in the client platform.

Related Issues

  • Closes #14

mrverdant13 avatar Mar 15 '22 06:03 mrverdant13

@mrverdant13 great start on this, let me know when you think it's ready for review. I noticed some tests are still failing explicitly relating to these changes

Salakar avatar Mar 21 '22 13:03 Salakar

:wave:

Do you still plan on working on this?

rrousselGit avatar Oct 07 '22 13:10 rrousselGit

It appears that you have given-up on this PR, so I'll close this.

Feel free to open a new PR if you want to resume this :)

rrousselGit avatar Mar 08 '23 12:03 rrousselGit