react-native-material-design icon indicating copy to clipboard operation
react-native-material-design copied to clipboard

Update ripple polyfil to support flex on the touchable

Open mlabrum opened this issue 7 years ago • 4 comments

Hey,

I found that on IOS the TouchableOpacity won't respect the child flex (where TouchableNativeFeedback seems to) and that it sometimes requires a kick to force it to flex

pre flex touchable-pre

after flex touchable-after

(Trying to make the whole area a button)

mlabrum avatar Jul 28 '16 07:07 mlabrum

Could we not use the existing style prop to pass this along - Incase other styles other than flex are wanted? Thoughts?

Salakar avatar Sep 02 '16 11:09 Salakar

the existing style prop updates the inner and outer View within the IOS TouchableOpacity, I needed to be able to set styles directly on the outer container of TouchableOpacity, to be able to get the flex needed

We could adjust this to be a generic touchableOpacityStyles prop?

mlabrum avatar Sep 06 '16 00:09 mlabrum

Better innerStyle/outerSyle handling that works the same with and without the polyfill would be better.

dantman avatar Feb 09 '17 06:02 dantman

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 11 '19 23:07 CLAassistant