react-native-material-design icon indicating copy to clipboard operation
react-native-material-design copied to clipboard

Toolbar alignment with FB examples and plugability

Open ssomnoremac opened this issue 9 years ago • 0 comments

I'm finding it difficult to implement the Toolbar for a number of reasons:

  • Alignment to conventions used by the FB version of Toolbar

onIconClicked() becomes onIconPress() for example is annoying also style like below is giving me a warning about Invalid prop of type number

   header: {
     backgroundColor: '#F44336',
     height: 56,
   }

I understand why theme is introduced but styles should be supported (I do like the right icon style)

  • Plugability.

Navigation convention used by the example is a bit complex. I tried just implementing my current drawer solution onIconPress={() => this.drawer.openDrawer()} without success. It fired a different action.

  • No search bar solution

Am I wrong here? Does the Toolbar support inserting content besides icons and text? If so, I'd love to see it in the example.

I would like to contribute to this project but would like to hear if any of these concerns are shared. Great work otherwise!

ssomnoremac avatar Jan 28 '16 17:01 ssomnoremac