react-native-material-design icon indicating copy to clipboard operation
react-native-material-design copied to clipboard

Upgrade to use separate proptypes library for react 16

Open suark opened this issue 7 years ago • 4 comments

In react 16 and up, React.Proptypes no longer exists. Instead we must use the new, separate proptypes library:
https://github.com/facebook/prop-types

react-native version 0.49 uses react 16 https://github.com/facebook/react-native/blob/v0.49.0/package.json#L135

So react-native-material-design must be updated or it will be remain incompatible with newer versions of react-native.

I have removed any references to the React.proptypes while also updating the dependency of react-native-vector-icons

That dependency has been updated to use the correct proptypes so we only have to update to the newest and it is fine.

I ran the linting and noticed that the master branch contains roughly 220 linting errors and after my changes, it still has the exact same number. So my PR should not be rejected due to linting errors that I did not cause.

Should resolve #170

suark avatar Oct 24 '17 18:10 suark

Please merge this PR

amensouissi avatar Dec 14 '17 22:12 amensouissi

+1 to please merge this PR

tbarsbay avatar Mar 15 '18 20:03 tbarsbay

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 11 '19 23:07 CLAassistant

hopefully this is still possible. I deleted my fork haha. It was made almost 2 years ago

suark avatar Jul 31 '19 22:07 suark