react-native-material-design icon indicating copy to clipboard operation
react-native-material-design copied to clipboard

0.4.0 Release

Open Ehesp opened this issue 8 years ago • 29 comments

This list is a work in progress

  • [ ] Refactor List component
  • [ ] Implement GridView component
  • [ ] Implement Floating Action Button (FAB)
  • [ ] Swipe Views with Tabs (spec). Create a wrapper around react-native-scrollable-tab-view - maybe?
  • [x] ~~Animated IconToggle badge changes.~~ https://github.com/react-native-material-design/react-native-material-design/commit/c8f762eb988485fc614069f4dbe4811e5127ceb2 Released in 0.3.1
  • [x] ~~Create a core Ripple component, which handles device type~~ https://github.com/react-native-material-design/react-native-material-design/commit/a0fc633c451c66d861fd93ba34fd1030213c9907
  • [x] ~~Attempt to implement TouchableWithoutFeedback on polyfil/Ripple to properly handle onLong press and other props.~~ https://github.com/react-native-material-design/react-native-material-design/commit/b537e1cdb2fa7844bf7c9830cbcedd909ba03f72
  • [ ] NavIgation Drawer expandable/collapsable sections.

Ehesp avatar Jan 03 '16 17:01 Ehesp

Anything more planned for 0.4.0, that I can take up? I guess you are handling the List Refactor.

bozzmob avatar Jan 05 '16 20:01 bozzmob

The GridComponent? Also I need to debug a Ripple bug where the state persists. Any other ideas I'm open to!

Ehesp avatar Jan 05 '16 20:01 Ehesp

What about a FAB?

dgilperez avatar Jan 05 '16 21:01 dgilperez

Ah yeah. How should the position of it be done? Simply render the FAB and let the user decide where to place it? On 5 Jan 2016 9:00 p.m., "David Gil" [email protected] wrote:

What about a FAB?

— Reply to this email directly or view it on GitHub https://github.com/react-native-material-design/react-native-material-design/issues/12#issuecomment-169132655 .

Ehesp avatar Jan 05 '16 21:01 Ehesp

Hmm not really sure. Specs about fabs say how they should be positioned with relation to other objects, and they seem to be always bottom-right ... Maybe we can style them lime that by default and let the user override?

El mar, 5 de enero de 2016 22:02, Elliot Hesp [email protected] escribió:

Ah yeah. How should the position of it be done? Simply render the FAB and let the user decide where to place it? On 5 Jan 2016 9:00 p.m., "David Gil" [email protected] wrote:

What about a FAB?

— Reply to this email directly or view it on GitHub < https://github.com/react-native-material-design/react-native-material-design/issues/12#issuecomment-169132655

.

— Reply to this email directly or view it on GitHub https://github.com/react-native-material-design/react-native-material-design/issues/12#issuecomment-169133138 .

dgilperez avatar Jan 05 '16 22:01 dgilperez

What about a Bottom Sheet?

pewh avatar Jan 06 '16 02:01 pewh

Yes. The FAB has to be at the bottom-right according to the spec. Though FAB comes in handy, but, personally I somewhat like this article - Why the Floating Action Button is bad UX design

@Ehesp I can have a look at FAB, Gridview.

bozzmob avatar Jan 06 '16 05:01 bozzmob

With respect to Grid View, I will be implementing this first (from the spec)-

image

bozzmob avatar Jan 06 '16 05:01 bozzmob

@pewh problem with a bottom sheet is that currently there's no way to force a component to the top of everything else (I believe).

Ehesp avatar Jan 06 '16 07:01 Ehesp

@pewh @Ehesp There is a way to do that. But, not sure its available on Android yet. We can tweak concepts and code from the Modal and implement it I believe. I have seen such an implementation somewhere. Not sure how good or feasible it is.

bozzmob avatar Jan 06 '16 10:01 bozzmob

@bozzmob Okay cool - Shall look into it.

What does everyone think of 'Swipe Views with Tabs'? I've got it working on another project using the project mentioned in the list, but had to create a custom tab bar to make it feel native...?

Ehesp avatar Jan 06 '16 10:01 Ehesp

jan 06 2016 19 13

Badge animations done!

Salakar avatar Jan 06 '16 19:01 Salakar

@Ehesp Yeah! There is a ViewPager component which exists officially. We can make use of react-native-scrollable-tab-view as you have suggested. But, some css changes are needed so that the look and feel is similar to the existing components.

bozzmob avatar Jan 06 '16 19:01 bozzmob

Nice work @Salakar, really cool.

@bozzmob I'll do that then as I've already got it on another project. react-native-scrollable-tab-view doesn't allow a single tab too, but I've got a way around that.

Ehesp avatar Jan 06 '16 19:01 Ehesp

@Ehesp How about we use react-native-action-button for FAB?

bozzmob avatar Jan 06 '16 19:01 bozzmob

That looks good! Will look if there's any benefit of pulling it in and making a wrapper around it. If not, it might just be best to suggest this for a FAB.

Ehesp avatar Jan 06 '16 21:01 Ehesp

A dropdown menu component could be awesome! But maybe it's a lot of work if it's a complete implementation (buttons, + textfields)

zoontek avatar Jan 07 '16 12:01 zoontek

@zoontek I agree, however part of the problem we have (Bottom Sheets has this issue too), is that React Native does not yet support an "on the top of everything" API. So the dropdown menu might get stuck behind a component which is nested deeper down the chain.

Ehesp avatar Jan 07 '16 12:01 Ehesp

I am working on the Gridview component now. Have made some progress. Still a lot to do.

bozzmob avatar Jan 07 '16 18:01 bozzmob

Screenshots of Gridview-

Currently, its working for a fixed height, width.

I am working on making it a generic component. Currently most values like margin, padding are being hard-coded. So, thought of making it responsive.

image

image

bozzmob avatar Jan 07 '16 19:01 bozzmob

@bozzmob any updates on the grid view?

Salakar avatar Jan 11 '16 17:01 Salakar

@Salakar Yes. I am working on it. It should be available in a couple of days.

bozzmob avatar Jan 12 '16 06:01 bozzmob

The dropdown is available in React-Native 0.19-rc: https://github.com/facebook/react-native/commit/18437093f2664beedd3239bb525d7daa3f2bcdbd :+1:

zoontek avatar Jan 25 '16 08:01 zoontek

Awesome :D

I just wish there was some "z-index" type style so we could push whatever we wanted to the top of the stack.

Ehesp avatar Jan 25 '16 08:01 Ehesp

Is the project dead? :(

zoontek avatar Feb 29 '16 10:02 zoontek

Nope, was using it in a internal work project however that's not currently being developed so focus has shifted. Plan on picking it up in the next few weeks hopefully.

Ehesp avatar Feb 29 '16 10:02 Ehesp

Great!

zoontek avatar Feb 29 '16 10:02 zoontek

@Ehesp Any chance to integrate with https://github.com/xinthink/react-native-material-kit?

anhldbk avatar Mar 07 '16 02:03 anhldbk

I would like to have a proper dialog (in future releases), example: https://github.com/aakashns/react-native-dialogs

kkgelu avatar Mar 11 '16 00:03 kkgelu