react-native-google-mobile-ads icon indicating copy to clipboard operation
react-native-google-mobile-ads copied to clipboard

docs(ios): note that pod install is required to see ios_config.sh changes

Open mikehardy opened this issue 4 months ago • 1 comments

Description

This wastes developer's time, we should warn them

Related issues

Related:

  • #547 - developer confusion

Release Summary

docs only, no release

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [x] Yes
  • My change supports the following platforms;
    • [ ] Android
    • [x] iOS
  • My change includes tests;
    • [ ] e2e tests added or updated in __tests__e2e__
    • [ ] jest tests added or updated in __tests__
  • [ ] I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • [ ] Yes
    • [x] No

Test Plan

No tests needed, all comments


Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:

  • 👉 Star this repo on GitHub ⭐️
  • 👉 Follow Invertase on Twitter

mikehardy avatar Feb 19 '24 15:02 mikehardy

Codecov Report

Merging #550 (f7bee6c) into main (7aef863) will not change coverage. Report is 1 commits behind head on main. The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #550   +/-   ##
=======================================
  Coverage   43.66%   43.66%           
=======================================
  Files          29       29           
  Lines         536      536           
  Branches      147      147           
=======================================
  Hits          234      234           
  Misses        302      302           

codecov[bot] avatar Feb 19 '24 15:02 codecov[bot]

This is in place in react-native-firebase, no issues

mikehardy avatar Feb 26 '24 12:02 mikehardy

(it will trigger a project.pbxproj change in the example project on next example project pod install)

mikehardy avatar Feb 26 '24 12:02 mikehardy

:tada: This PR is included in version 13.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

mikehardy avatar Mar 05 '24 18:03 mikehardy