react-native-google-mobile-ads
react-native-google-mobile-ads copied to clipboard
[Feature Request] Support the max height option for inline adaptive banners
What happened?
Inline adaptive banners are designed for scrolling content. If that content is a feed with fairly consistent cell sizes then the larger sizes of banner available can be terrible for the UX.
The native SDKs support a method to get an inline adaptive banner with a width and max height (rather than just a width) but we can't access this through the React Native SDK.
The standard banners don't work so well in a feed in practice because they always take up their fixed height while loading and the API doesn't provide any feedback on loading unless it fails.
It would be ideal if the BannerAd
component could take an optional max height that if supplied for an inline adaptive banner would cause the alternative native SDK method to be used and restrict the height. :pray:
Platforms
Android and iOS
React Native Info
All recent versions
Are your using Typescript?
- [ ] My project is using Typescript
package.json
n/a
app.json
n/a
ios/Podfile
No response
android/build.gradle
No response
android/app/build.gradle
No response
android/settings.gradle
No response
AndroidManifest.xml
No response
As this package is a community effort, it would be great if you can submit a Pull Request to make this happen!
Hello 👋, to help manage issues we automatically close stale issues.
This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?
This issue will be closed in 15 days if no further activity occurs.
Thank you for your contributions.