react-native-google-mobile-ads icon indicating copy to clipboard operation
react-native-google-mobile-ads copied to clipboard

chore: update example app / ci workflows

Open mikehardy opened this issue 7 months ago • 9 comments

Description

  • update javascript dependencies for module
  • update example
  • update github workflows

Related issues

Nothing in particular but I noticed the android CI task failed on #477 and wanted to clean things up in general to see if I could get it to go green just by having everything be cleaner + up to date

Release Summary

A bunch of conventional commits, this should be a rebase merge and that should drive the release correctly with one fix commit

I titled the PR with the correct thing in case I or who ever merges this assuming it goes green in CI forgets and squash merges :-)

Very careful attention should be paid to the release process as all the semantic release components were updated

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [ ] Yes
  • My change supports the following platforms;
    • [ ] Android
    • [ ] iOS
  • My change includes tests;
    • [ ] e2e tests added or updated in __tests__e2e__
    • [ ] jest tests added or updated in __tests__
  • [ ] I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • [ ] Yes
    • [ ] No

Test Plan

Lots of local runs of the example app and refresh-example script


Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:

  • 👉 Star this repo on GitHub ⭐️
  • 👉 Follow Invertase on Twitter

mikehardy avatar Nov 08 '23 02:11 mikehardy

Strange - worked locally but obviously needs some work here!

mikehardy avatar Nov 08 '23 02:11 mikehardy

Do you need help with this @mikehardy ?

MateusAndrade avatar Nov 20 '23 15:11 MateusAndrade

Do you need help with this @mikehardy ?

Sure @MateusAndrade - not sure how approachable it is as a problem and hasn't been the highest of priorities but if you or someone else doesn't work through all the little errors I made then I'll certainly have to 😆 . Have at it if you want to as I won't have time to come around to it for a few days at minimum

mikehardy avatar Nov 20 '23 15:11 mikehardy

Do you need help with this @mikehardy ?

Sure @MateusAndrade - not sure how approachable it is as a problem and hasn't been the highest of priorities but if you or someone else doesn't work through all the little errors I made then I'll certainly have to 😆 . Have at it if you want to as I won't have time to come around to it for a few days at minimum

Sure! Would it be okay to fork your/update my fork with your changes?

MateusAndrade avatar Nov 20 '23 15:11 MateusAndrade

Yeah - literally whatever seems like it would work, as a workflow. Pretty informal here with regard to process as long as everyone tries their best (which we all do, so it works out...)

mikehardy avatar Nov 20 '23 15:11 mikehardy

will pick this up again now that holidays are over, if no one else does. JDK21 is a viable dev platform now as well, can start qualifying that...

mikehardy avatar Jan 08 '24 22:01 mikehardy

This no longer has anything to do with SDK updates and is purely focused on cleaning up CI + the example app.

mikehardy avatar Jan 12 '24 16:01 mikehardy

Down to one final thing to fix, which I reproduce locally with yarn tests:jest:


    SyntaxError: /home/runner/work/react-native-google-mobile-ads/react-native-google-mobile-ads/src/ads/GoogleMobileAdsBannerViewNativeComponent.ts: 'Commands' is a reserved export and may only be used to export the result of codegenNativeCommands.
      34 | // SyntaxError "'Commands' is a reserved export and may only be used to export the result of codegenNativeCommands"
      35 | // @ts-ignore -- migration to react-native 0.73
    > 36 | export const Commands: NativeCommands = codegenNativeCommands<NativeCommands>({
         | ^
      37 |   supportedCommands: ['recordManualImpression'],
      38 | });
      39 |

...working on it bit by bit

mikehardy avatar Jan 13 '24 17:01 mikehardy

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Feb 12 '24 12:02 github-actions[bot]

I didn't have time to circle back to this - it was really really close though

mikehardy avatar Mar 01 '24 04:03 mikehardy

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Mar 29 '24 04:03 github-actions[bot]