react-native-google-mobile-ads
react-native-google-mobile-ads copied to clipboard
fix(ios): correctly handle utf-8 chars in ios-config.sh
Description
If your app.json had an app name or displayName with UTF-8 chars, ruby was not handling it and would fail to find the ios_app_id which broke the build.
With the help of @gawa1019 and others on #194 I was finally able to reproduce this and fix it (I think)
Related issues
Fixes #194
Release Summary
conventional commit
Checklist
- I read the Contributor Guide
and followed the process outlined there for submitting PRs.
- [x] Yes
- My change supports the following platforms;
- [ ]
Android
- [x]
iOS
- [ ]
- My change includes tests;
- [ ]
e2e
tests added or updated in__tests__e2e__
- [ ]
jest
tests added or updated in__tests__
- [ ]
- [ ] I have updated TypeScript types that are affected by my change.
- This is a breaking change;
- [ ] Yes
- [x] No
Test Plan
1- Added UTF-8 chars to my app.json as per #194 failure examples
2- I had rvm installed so mv ~.rvm ~.rvmTEMP
to make sure I was using system ruby
3- yarn example:install && yarn example:install:pods
3- open RNGM*Example/ios/*.xcworkspace
to open the example workspace in Xcode (it does not reproduce in Terminal all the time...)
4- do the build
It seemed to fail for me before the change but now it works
Think react-native-google-mobile-ads
is great? Please consider supporting the project with any of the below:
- 👉 Star this repo on GitHub ⭐️
- 👉 Follow
Invertase
on Twitter
Codecov Report
Merging #227 (9d61dce) into main (d74be31) will not change coverage. The diff coverage is
n/a
.
:exclamation: Current head 9d61dce differs from pull request most recent head 61ae80e. Consider uploading reports for the commit 61ae80e to get more accurate results
@@ Coverage Diff @@
## main #227 +/- ##
=======================================
Coverage 22.59% 22.59%
=======================================
Files 34 34
Lines 806 806
Branches 199 199
=======================================
Hits 182 182
Misses 624 624
Requested testers on the related issue, will merge by default in a week or so, but hopefully someone tests and it's good
Somehow I didn't use utf-8 characters for my previous apps, even though I'm Korean.😅 Great finding.
I have heard basically no feedback, but...it worked for me and I was able to reproduce the problem. Going to merge and release :shrug:
:tada: This PR is included in version 8.1.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket: