react-native-google-mobile-ads icon indicating copy to clipboard operation
react-native-google-mobile-ads copied to clipboard

fix(android, sdk): passing custom targeting as array of string instead of string

Open AbdelhalimAhmed opened this issue 3 years ago • 3 comments

Description

When passing customTargeting as Array of string instead of string the app is crashed.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [x] Yes
  • My change supports the following platforms;
    • [x] Android
    • [ ] iOS
  • My change includes tests;
    • [ ] e2e tests added or updated in __tests__e2e__
    • [ ] jest tests added or updated in __tests__
  • [x] I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • [ ] Yes
    • [x] No

Test Plan

https://developers.google.com/android/reference/com/google/android/gms/ads/admanager/AdManagerAdRequest.Builder#public-admanageradrequest.builder-addcustomtargeting-string-key,-liststring-values

Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:

  • 👉 Star this repo on GitHub ⭐️
  • 👉 Follow Invertase on Twitter

AbdelhalimAhmed avatar Aug 30 '22 08:08 AbdelhalimAhmed

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 30 '22 08:08 CLAassistant

Hi! Thank you for contributing to our repo. Does this change work with iOS, too?

wjaykim avatar Sep 01 '22 00:09 wjaykim

yes, works fine

AbdelhalimAhmed avatar Sep 08 '22 10:09 AbdelhalimAhmed

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Dec 05 '22 20:12 github-actions[bot]