react-native-google-mobile-ads
react-native-google-mobile-ads copied to clipboard
fix(android, sdk): passing custom targeting as array of string instead of string
Description
When passing customTargeting as Array of string instead of string the app is crashed.
Checklist
- I read the Contributor Guide
and followed the process outlined there for submitting PRs.
- [x] Yes
- My change supports the following platforms;
- [x]
Android - [ ]
iOS
- [x]
- My change includes tests;
- [ ]
e2etests added or updated in__tests__e2e__ - [ ]
jesttests added or updated in__tests__
- [ ]
- [x] I have updated TypeScript types that are affected by my change.
- This is a breaking change;
- [ ] Yes
- [x] No
Test Plan
https://developers.google.com/android/reference/com/google/android/gms/ads/admanager/AdManagerAdRequest.Builder#public-admanageradrequest.builder-addcustomtargeting-string-key,-liststring-values
Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:
- 👉 Star this repo on GitHub ⭐️
- 👉 Follow
Invertaseon Twitter
Hi! Thank you for contributing to our repo. Does this change work with iOS, too?
yes, works fine
Hello 👋, this PR has been opened for more than 2 months with no activity on it.
If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!
You have 15 days until this gets closed automatically