react-native-google-mobile-ads icon indicating copy to clipboard operation
react-native-google-mobile-ads copied to clipboard

Extend AdSize support to handle size=FLUID

Open wjaykim opened this issue 3 years ago • 4 comments

Extend AdSize support to handle size=FLUID

Originally posted by @mikehardy in https://github.com/invertase/react-native-google-mobile-ads/pull/105#discussion_r858917392

wjaykim avatar Apr 27 '22 07:04 wjaykim

This issue is holding up our release on Android, and we've been working with various partners trying to figure it out. How can we help?

djMax avatar Apr 29 '22 19:04 djMax

Best way to help is to work with us directly here and propose a PR, you can see by the collaboration on previous PRs how quickly things can go in and release

Bonus - just by proposing a PR, even without maintainer attention, you get a clean set of test patches you can apply against the current public release, for integration via patch-package - https://github.com/invertase/react-native-google-mobile-ads/actions/workflows/create_test_patches.yml - so you can throw a PR up and immediately (well, a few minutes) integrate the patch in an app to see how it works for you

mikehardy avatar Apr 29 '22 19:04 mikehardy

These are the lines that drive local development:

https://github.com/invertase/react-native-google-mobile-ads/blob/bdd66dea5d8bee522222aeb3968c5e44c8856628/package.json#L83-L99

Along with adding a new test case here and adding it to the list of test cases so you may interact with the new code: https://github.com/invertase/react-native-google-mobile-ads/blob/main/RNGoogleMobileAdsExample/App.tsx

mikehardy avatar Apr 29 '22 20:04 mikehardy

There is no question this is wrong, but just as a start: https://github.com/invertase/react-native-google-mobile-ads/pull/130

djMax avatar May 03 '22 16:05 djMax

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

github-actions[bot] avatar Dec 05 '22 20:12 github-actions[bot]