react-native-firebase icon indicating copy to clipboard operation
react-native-firebase copied to clipboard

feat(expo): enhances notification config retrieval

Open huextrat opened this issue 4 months ago • 11 comments

Description

Expo 54 will deprecate the use of notification in expo config in favor of expo-notifications expo plugin : https://docs.expo.dev/versions/v54.0.0/config/app/#notification

Improves notification configuration by first checking expo-notifications plugin for icon and color.

Falls back to deprecated config.notification settings. Warns about missing notification icon for Android.

Related issues

fixes: https://github.com/invertase/react-native-firebase/issues/8664

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [X] Yes
  • My change supports the following platforms;
    • [X] Android
    • [X] iOS
    • [X] Other (macOS, web)
  • My change includes tests;
    • [X] e2e tests added or updated in packages/\*\*/e2e
    • [X] jest tests added or updated in packages/\*\*/__tests__
  • [X] I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • [ ] Yes
    • [X] No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

huextrat avatar Aug 21 '25 11:08 huextrat

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
react-native-firebase Ready Ready Preview Comment Sep 23, 2025 3:42pm

vercel[bot] avatar Aug 21 '25 11:08 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 21 '25 11:08 CLAassistant

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Sep 18 '25 12:09 github-actions[bot]

Ping @mikehardy - @MichaelVerdon to get your opinion on this

huextrat avatar Sep 18 '25 13:09 huextrat

just closing and reopening to make sure CI runs, it appears to be hung for some reason

mikehardy avatar Sep 23 '25 13:09 mikehardy

just closing and reopening to make sure CI runs, it appears to be hung for some reason

I did a rebase on latest main + fix lint

huextrat avatar Sep 23 '25 13:09 huextrat

duplicate test b2637599164e42220b6aec14faf74e1dfddb6bf0 to make sure both configuration are working

huextrat avatar Sep 23 '25 13:09 huextrat

Any ETA for next version with this change?

huextrat avatar Oct 09 '25 07:10 huextrat

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Nov 06 '25 07:11 github-actions[bot]

Ping @mikehardy @MichaelVerdon, this is not stale

huextrat avatar Nov 06 '25 07:11 huextrat

apologies for the delay - been spinning through all the Invertase npmjs packages implementing their new Trusted Publish thing so we can keep releasing software at all, and it's delayed me going through PRs here. This is on the radar though

mikehardy avatar Nov 06 '25 23:11 mikehardy