react-native-firebase icon indicating copy to clipboard operation
react-native-firebase copied to clipboard
verified publisher icon invertase

fix(docs): add a necessary await operator to the example code for initializeAppCheck()

Open aike19115 opened this issue 6 months ago • 2 comments

Something else, the link to the Contributor Guide that is in the template when you create a pull request gives a 404: Contributor Guide

https://github.com/invertase/react-native-firebase/CONTRIBUTING.md

aike19115 avatar Jun 13 '25 06:06 aike19115

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2025 5:22pm

vercel[bot] avatar Jun 13 '25 06:06 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 13 '25 06:06 CLAassistant

Thanks for the mention that the CONTRIBUTING doc was 404 in the PR template - was a problem with pathing not being as expected when the template was actually in use, vs just being examine in the file tree

https://github.com/invertase/react-native-firebase/commit/b7782108f9d3cb620105bdc84e140ac8681d7e30

mikehardy avatar Jun 30 '25 06:06 mikehardy

@mikehardy done

aike19115 avatar Jun 30 '25 07:06 aike19115

This will conflict with another PR about to go in but I'll do the fixup and get this one in after

  • #8573

mikehardy avatar Jun 30 '25 16:06 mikehardy

Fixed conflict after a rebase to main, will merge pending CI

mikehardy avatar Jun 30 '25 17:06 mikehardy