react-native-firebase icon indicating copy to clipboard operation
react-native-firebase copied to clipboard

fix(analytics): typo in type declarations

Open matinzd opened this issue 1 year ago • 4 comments

Description

Fix typo in type declaration

Related issues

N/A

Release Summary

Fix typo in type declarations

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [x] Yes
  • My change supports the following platforms;
    • [ ] Android
    • [x] iOS
  • My change includes tests;
    • [ ] e2e tests added or updated in packages/\*\*/e2e
    • [ ] jest tests added or updated in packages/\*\*/__tests__
  • [x] I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • [ ] Yes
    • [x] No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

matinzd avatar Sep 11 '24 14:09 matinzd

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 2:41pm

vercel[bot] avatar Sep 11 '24 14:09 vercel[bot]

@mikehardy @russellwheatley ?

matinzd avatar Oct 09 '24 10:10 matinzd

Yeah actually it was my fault here :))

https://github.com/invertase/react-native-firebase/pull/7963

This got lost in between of all those changes.

matinzd avatar Oct 09 '24 14:10 matinzd

Bonus points for owning your own mistake vs hit-and-run-never-return PRs 😆 🤜 🤛

mikehardy avatar Oct 09 '24 14:10 mikehardy