react-native-firebase icon indicating copy to clipboard operation
react-native-firebase copied to clipboard

Extend Sign in with Apple OAuth Provider - add ability to set full name

Open mikehardy opened this issue 5 months ago • 4 comments

With release 10.7.0 of firebase-ios-sdk the auth module gained the ability to set the full name for sign in with apple: https://firebase.google.com/support/release-notes/ios#authentication_7

The OAuth provider likely needs an extension to accept the new parameter (hopefully optional...at least at the javascript layer here) and then call the new API signature in the underlying firebase-ios-sdk

Likely location to add new parameter for the full name in the Apple OAuth credential creation:

https://github.com/invertase/react-native-firebase/blob/ff32fd37b39557e9a55fce016cbf986348436b92/packages/auth/lib/providers/AppleAuthProvider.js#L29-L34

Likely location to swap out the current more generic OAuthProvider call for the apple-specific one mentioned here https://github.com/firebase/firebase-ios-sdk/issues/4393#issuecomment-1478733407:

https://github.com/invertase/react-native-firebase/blob/ff32fd37b39557e9a55fce016cbf986348436b92/packages/auth/ios/RNFBAuth/RNFBAuthModule.m#L1349-L1351

PRs welcome! Confirmed that it is tested and working locally critical...

As mentioned in #4046

mikehardy avatar Jan 31 '24 14:01 mikehardy