react-native-firebase icon indicating copy to clipboard operation
react-native-firebase copied to clipboard

fix: export modular types

Open touchmarine opened this issue 1 year ago • 14 comments

Fixes typescript error:

Module '"@react-native-firebase/x"' has no exported member 'y'.
Did you mean to use 'import y from "@react-native-firebase/x" instead?' [2164]"

Description

Typescript types weren't working for the firestore's new modular API. This pull request exports modular typings in all packages that have them.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [x] Yes
  • My change supports the following platforms;
    • [x] Android
    • [x] iOS
  • My change includes tests;
    • [ ] e2e tests added or updated in packages/\*\*/e2e
    • [ ] jest tests added or updated in packages/\*\*/__tests__
  • [x] I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • [ ] Yes
    • [x] No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

:fire:

touchmarine avatar Oct 10 '23 22:10 touchmarine

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 10:21pm
react-native-firebase-next ❌ Failed (Inspect) Oct 10, 2023 10:21pm

vercel[bot] avatar Oct 10 '23 22:10 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 10 '23 22:10 CLAassistant

Hey @touchmarine 👋 ! Thanks for this. Could you follow the details link on the check for the CLA to see why it's not passing, and make sure you sign the CLA in a way that the check passes? Thank you!

mikehardy avatar Oct 10 '23 23:10 mikehardy

Hi @mikehardy, I've signed the CLA now.

touchmarine avatar Oct 11 '23 12:10 touchmarine

Thank you for signing the CLA! Note I just merged an ML api v9 thing, so I need to add a commit that works with that, I'm happy to shepherd it through, no action needed on your part

mikehardy avatar Oct 15 '23 15:10 mikehardy

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Nov 12 '23 15:11 github-actions[bot]

Just a note that this is definitely on our radar here - apologies it has gone stale

mikehardy avatar Nov 27 '23 13:11 mikehardy

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Dec 27 '23 00:12 github-actions[bot]

not stale (well, stale, but not heading for auto-close)

mikehardy avatar Jan 06 '24 19:01 mikehardy

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Feb 03 '24 20:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.43%. Comparing base (c9b695a) to head (1d5fb5c). Report is 197 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #7403       +/-   ##
=============================================
- Coverage     68.61%   51.43%   -17.18%     
- Complexity        0      759      +759     
=============================================
  Files           145      251      +106     
  Lines          5855    13485     +7630     
  Branches       1235     2176      +941     
=============================================
+ Hits           4017     6935     +2918     
- Misses         1743     6162     +4419     
- Partials         95      388      +293     

codecov[bot] avatar Feb 19 '24 03:02 codecov[bot]

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Mar 22 '24 13:03 github-actions[bot]

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Apr 19 '24 14:04 github-actions[bot]

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar May 17 '24 16:05 github-actions[bot]

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Jun 14 '24 17:06 github-actions[bot]