react-native-firebase
react-native-firebase copied to clipboard
fix: export modular types
Fixes typescript error:
Module '"@react-native-firebase/x"' has no exported member 'y'.
Did you mean to use 'import y from "@react-native-firebase/x" instead?' [2164]"
Description
Typescript types weren't working for the firestore's new modular API. This pull request exports modular typings in all packages that have them.
Related issues
Release Summary
Checklist
- I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] Yes
- My change supports the following platforms;
- [x]
Android
- [x]
iOS
- [x]
- My change includes tests;
- [ ]
e2e
tests added or updated inpackages/\*\*/e2e
- [ ]
jest
tests added or updated inpackages/\*\*/__tests__
- [ ]
- [x] I have updated TypeScript types that are affected by my change.
- This is a breaking change;
- [ ] Yes
- [x] No
Test Plan
Think react-native-firebase
is great? Please consider supporting the project with any of the below:
- 👉 Star this repo on GitHub ⭐️
- 👉 Follow
React Native Firebase
andInvertase
on Twitter
:fire:
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
react-native-firebase | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 10, 2023 10:21pm |
react-native-firebase-next | ❌ Failed (Inspect) | Oct 10, 2023 10:21pm |
Hey @touchmarine 👋 ! Thanks for this. Could you follow the details link on the check for the CLA to see why it's not passing, and make sure you sign the CLA in a way that the check passes? Thank you!
Hi @mikehardy, I've signed the CLA now.
Thank you for signing the CLA! Note I just merged an ML api v9 thing, so I need to add a commit that works with that, I'm happy to shepherd it through, no action needed on your part
Hello 👋, this PR has been opened for more than 2 months with no activity on it.
If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!
You have 15 days until this gets closed automatically
Just a note that this is definitely on our radar here - apologies it has gone stale
Hello 👋, this PR has been opened for more than 2 months with no activity on it.
If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!
You have 15 days until this gets closed automatically
not stale (well, stale, but not heading for auto-close)
Hello 👋, this PR has been opened for more than 2 months with no activity on it.
If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!
You have 15 days until this gets closed automatically
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 51.43%. Comparing base (
c9b695a
) to head (1d5fb5c
). Report is 197 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #7403 +/- ##
=============================================
- Coverage 68.61% 51.43% -17.18%
- Complexity 0 759 +759
=============================================
Files 145 251 +106
Lines 5855 13485 +7630
Branches 1235 2176 +941
=============================================
+ Hits 4017 6935 +2918
- Misses 1743 6162 +4419
- Partials 95 388 +293
Hello 👋, this PR has been opened for more than 2 months with no activity on it.
If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!
You have 15 days until this gets closed automatically
Hello 👋, this PR has been opened for more than 2 months with no activity on it.
If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!
You have 15 days until this gets closed automatically
Hello 👋, this PR has been opened for more than 2 months with no activity on it.
If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!
You have 15 days until this gets closed automatically
Hello 👋, this PR has been opened for more than 2 months with no activity on it.
If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!
You have 15 days until this gets closed automatically