react-native-firebase icon indicating copy to clipboard operation
react-native-firebase copied to clipboard

feat(auth): Add Expo support for phone auth #6167

Open pduggi-cf opened this issue 1 year ago • 9 comments

Add @react-native-firebase/auth config plugin, which enables captcha for phone auth by modifying Info.Plist. The config plugin is automating the reCAPTCHA verification steps from the firebase iOS docs. Add docs to the Phone Auth page for Expo users.

Sorry for some reason the checklist didn't show up here when I created the PR. I'll try to find it.

Related: https://github.com/invertase/react-native-firebase/issues/5936

Updating PR #6167

pduggi-cf avatar Aug 16 '22 07:08 pduggi-cf

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview Aug 16, 2022 at 7:24AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Aug 16, 2022 at 7:24AM (UTC)

vercel[bot] avatar Aug 16 '22 07:08 vercel[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: nandorojo
:x: Prashanth kumar Duggishetti


Prashanth kumar Duggishetti seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 16 '22 07:08 CLAassistant

@nandorojo thanks for the original PR

pduggi-cf avatar Aug 16 '22 07:08 pduggi-cf

Hey @pduggi-cf this seems great! Thanks for picking it up and pushing it forward, I appreciate it. I also appreciate your patience, I was traveling and I am just now getting caught back up so I can process PRs again.

It looks like this is just missing the CLA signed by you - can you do that by following either the Details link in the failing check on it or in the comment above? Thanks!

mikehardy avatar Aug 26 '22 22:08 mikehardy

Codecov Report

Merging #6472 (7895d43) into main (dc74643) will decrease coverage by 0.74%. The diff coverage is n/a.

:exclamation: Current head 7895d43 differs from pull request most recent head 92c24a6. Consider uploading reports for the commit 92c24a6 to get more accurate results

@@             Coverage Diff              @@
##               main    #6472      +/-   ##
============================================
- Coverage     54.90%   54.17%   -0.73%     
+ Complexity      689      680       -9     
============================================
  Files           208      208              
  Lines         10358    10358              
  Branches       1645     1645              
============================================
- Hits           5686     5610      -76     
- Misses         4371     4463      +92     
+ Partials        301      285      -16     

codecov[bot] avatar Aug 26 '22 22:08 codecov[bot]

@mikehardy image

I have signed it a while ago not sure why it says my CLA signature is still pending

pduggi-cf avatar Aug 27 '22 03:08 pduggi-cf

x Prashanth kumar Duggishetti

In my experience that is usually because the CLA was somehow signed with a different user (keyed by email address) than was expected here. Perhaps you are missing an email alias in your github account or something similar?

mikehardy avatar Aug 27 '22 13:08 mikehardy

image

image

I am not sure what to do now... i also used github to signing in fyi

pduggi-cf avatar Aug 28 '22 06:08 pduggi-cf

It looks like to two commits Dev dependies to yarn and yarn.lock are not associated with your email address. I would try to set up your email address in git and then recommit those two commits and force push.

DoctorJohn avatar Aug 30 '22 19:08 DoctorJohn

Hey @pduggi-cf! Just wondering if you're planning on trying to fix the CLA here again. I'd love to get this merged and use it in a Solito example app. Thanks again for picking it up.

nandorojo avatar Oct 02 '22 17:10 nandorojo

@nandorojo sorry, for some reason I thought this was already merged, I'll get to it later today. Thanks for bringing it back

pduggi-cf avatar Oct 03 '22 06:10 pduggi-cf

There is a conflict now and the CLA is still not signed, but I did add hacktoberfeft-accepted tag in case someone wants that ;-)

mikehardy avatar Oct 21 '22 12:10 mikehardy

Running around due to a medical emergency, might take a while

On Fri, Oct 21, 2022, 6:04 PM Mike Hardy @.***> wrote:

There is a conflict now and the CLA is still not signed, but I did add hacktoberfeft-accepted tag in case someone wants that ;-)

— Reply to this email directly, view it on GitHub https://github.com/invertase/react-native-firebase/pull/6472#issuecomment-1286902456, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASE4WKC73EH2W4QN2KBBKODWEKEU3ANCNFSM56UVRMOA . You are receiving this because you were mentioned.Message ID: @.***>

pduggi-cf avatar Oct 21 '22 16:10 pduggi-cf

Superceded by #6645

mikehardy avatar Oct 30 '22 16:10 mikehardy