react-native-firebase icon indicating copy to clipboard operation
react-native-firebase copied to clipboard

feat(android, app-check)!: Replaced SafetyNet with play integrity in android

Open krupal299 opened this issue 2 years ago • 4 comments

Description

  • Replaced SafetyNet with Play Integrity as SafetyNet is deprecated now in favour of play integrity https://developer.android.com/training/safetynet/deprecation-timeline
  • Reference - https://firebase.google.com/docs/app-check/android/safetynet-provider
  • No change required for iOS

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [x] Yes
  • My change supports the following platforms;
    • [x] Android
    • [ ] iOS
  • My change includes tests;
    • [ ] e2e tests added or updated in packages/\*\*/e2e
    • [ ] jest tests added or updated in packages/\*\*/__tests__
  • [ ] I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • [x] Yes
    • [ ] No

🔥

krupal299 avatar Jul 18 '22 13:07 krupal299

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 18 '22 13:07 CLAassistant

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview Jul 18, 2022 at 1:05PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Jul 18, 2022 at 1:05PM (UTC)

vercel[bot] avatar Jul 18 '22 13:07 vercel[bot]

Codecov Report

Merging #6402 (8f5da9a) into main (254f9fc) will decrease coverage by 46.48%. The diff coverage is n/a.

:exclamation: Current head 8f5da9a differs from pull request most recent head deb9312. Consider uploading reports for the commit deb9312 to get more accurate results

@@             Coverage Diff             @@
##             main    #6402       +/-   ##
===========================================
- Coverage   72.31%   25.84%   -46.47%     
===========================================
  Files         109       97       -12     
  Lines        4655     4289      -366     
  Branches     1048     1048               
===========================================
- Hits         3366     1108     -2258     
- Misses       1211     2581     +1370     
- Partials       78      600      +522     

codecov[bot] avatar Jul 18 '22 17:07 codecov[bot]

This will be a breaking change if/when merged

  • requires firebase developer console work
  • requires google play console work

https://firebase.google.com/docs/app-check/android/play-integrity-provider


Enable the Play Integrity API:

In the Google Play Console, select your app, or add it if you haven't already done so.

In the Release section, click Setup > App integrity.

On the Integrity API page, click Link project, then select your Firebase project from the list of Google Cloud projects.

The project you select here must be the same Firebase project as the one in which you register your app (see the next step).

Register your apps to use App Check with the Play Integrity provider in the App Check section of the Firebase console. You will need to provide the SHA-256 fingerprint of your app's signing certificate.

You usually need to register all of your project's apps, because once you enable enforcement for a Firebase product, only registered apps will be able to access the product's backend resources.

mikehardy avatar Jul 18 '22 17:07 mikehardy

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Dec 08 '22 18:12 github-actions[bot]

Should we reopen this and perhaps publish a major version or release candidate ?

kidculli avatar Jan 19 '23 05:01 kidculli