react-native-firebase icon indicating copy to clipboard operation
react-native-firebase copied to clipboard

docs(crashlytics): Add link to iOS symbol upload docs

Open lukebars opened this issue 2 years ago • 3 comments

Description

Currently docs are missing needed steps for iOS debug symbol upload, which you really want to have on crashlytics. I've added a link to firebase official documentation.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [x] Yes
  • My change supports the following platforms;
    • [ ] Android
    • [x] iOS
  • This is a breaking change;
    • [ ] Yes
    • [x] No

lukebars avatar May 17 '22 09:05 lukebars

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview May 17, 2022 at 9:10AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
react-native-firebase-next ⬜️ Ignored (Inspect) May 17, 2022 at 9:10AM (UTC)

vercel[bot] avatar May 17 '22 09:05 vercel[bot]

Hmm - this should be set up by default, there is no need to take extra steps I think. I get symbol uploads on build normally. However, it has a deeper problem: it is also not useful information, it leads to a false sense that things are working. More useful would be a discussion of why symbols uploaded from the local build are useless except for debug builds you are testing right then, and how to get useful symbols - I wrote it up here: https://stackoverflow.com/a/55796619/9910298

What do you think?

Hmm, we tried it on multiple projects and it doesn't include dSYM upload automatically. With added build phase it works perfectly fine, so that's not the situation which is listed in the stackoverflow issue.

Though I think we still should include dSYM either to build phases automatically or mention in the docs.

lukebars avatar Jun 02 '22 12:06 lukebars

Hmmm - this is definitely a documentation issue at least, we can improve this

As a user, do you want these uploaded by default? Or do you just want the option? I'm hesitant to upload them by default because the files are large and it takes time to process them etc.

But I like the idea of having the option, we could add a firebase.json option and parse that in the podspec, then on pod install we could refer to it in the podspec and install this script as thing to do after the build

/Pods/FirebaseCrashlytics/upload-symbols -gsp

Then regardless, a link to the writeup about the need to download bitcode-reprocessed dSYMs is probably useful

mikehardy avatar Jun 03 '22 20:06 mikehardy

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Dec 05 '22 19:12 github-actions[bot]