react-native-firebase
react-native-firebase copied to clipboard
fix(storage, refFromUrl): accept more complicated storage url formats WIP
Description
Apparently there are some corner case URLs that we do not handle correctly?
Not working yet
Related issues
Release Summary
Checklist
- I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [ ] Yes
- My change supports the following platforms;
- [ ]
Android
- [ ]
iOS
- [ ]
- My change includes tests;
- [ ]
e2e
tests added or updated inpackages/\*\*/e2e
- [ ]
jest
tests added or updated inpackages/\*\*/__tests__
- [ ]
- [ ] I have updated TypeScript types that are affected by my change.
- This is a breaking change;
- [ ] Yes
- [ ] No
Test Plan
Think react-native-firebase
is great? Please consider supporting the project with any of the below:
- 👉 Star this repo on GitHub ⭐️
- 👉 Follow
React Native Firebase
andInvertase
on Twitter
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.
react-native-firebase – ./
🔍 Inspect: https://vercel.com/invertase/react-native-firebase/BUEjDFWZy7fwo97cTCWZhGVG46ux
✅ Preview: https://react-native-firebase-git-mikehardy-storage-urls-invertase.vercel.app
react-native-firebase-next – ./website_modular
🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/9MpmGip4ND4KmTH3NbS75vPTUuKX
✅ Preview: Canceled
[Deployment for f67a970 canceled]
Codecov Report
Merging #5615 (4f1902d) into master (1e4fb9b) will decrease coverage by
50.47%
. The diff coverage is0.00%
.
:exclamation: Current head 4f1902d differs from pull request most recent head f67a970. Consider uploading reports for the commit f67a970 to get more accurate results
@@ Coverage Diff @@
## master #5615 +/- ##
===========================================
- Coverage 74.51% 24.04% -50.46%
===========================================
Files 109 95 -14
Lines 4487 4106 -381
Branches 957 960 +3
===========================================
- Hits 3343 987 -2356
- Misses 1068 2519 +1451
- Partials 76 600 +524
Hello 👋, this PR has been opened for more than 2 months with no activity on it.
If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!
You have 15 days until this gets closed automatically
This one came from the Flutter folks but I was not able to get it to work initially, needs re-shaping somehow :thinking:
Hello 👋, this PR has been opened for more than 2 months with no activity on it.
If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!
You have 15 days until this gets closed automatically