react-native-firebase icon indicating copy to clipboard operation
react-native-firebase copied to clipboard

feat(firestore): add OnSnapshotsInSync support

Open Ehesp opened this issue 3 years ago • 4 comments

Description

Adds support for onSnapshotsInSync API.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [x] Yes
  • My change supports the following platforms;
    • [x] Android
    • [x] iOS
  • My change includes tests;
    • [ ] e2e tests added or updated in packages/\*\*/e2e
    • [ ] jest tests added or updated in packages/\*\*/__tests__
  • [ ] I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • [ ] Yes
    • [x] No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Ehesp avatar Apr 12 '21 11:04 Ehesp

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/EgXBvPLz3ciFMrHima3pfykTdE4v
✅ Preview: https://react-native-firebase-git-ehesp-snapshots-in-sync-invertase.vercel.app

vercel[bot] avatar Apr 12 '21 11:04 vercel[bot]

Codecov Report

Merging #5159 (f54f0a4) into master (245149c) will decrease coverage by 51.85%. The diff coverage is n/a.

:exclamation: Current head f54f0a4 differs from pull request most recent head 2a97be0. Consider uploading reports for the commit 2a97be0 to get more accurate results

@@             Coverage Diff             @@
##           master    #5159       +/-   ##
===========================================
- Coverage   88.56%   36.71%   -51.84%     
===========================================
  Files         109       51       -58     
  Lines        3739     1512     -2227     
  Branches      358      358               
===========================================
- Hits         3311      555     -2756     
- Misses        383      729      +346     
- Partials       45      228      +183     

codecov[bot] avatar Apr 12 '21 11:04 codecov[bot]

There's an existing PR for this here: https://github.com/invertase/react-native-firebase/pull/4029 does this supersede that one? There was some notes on testing issues on the other one

Salakar avatar Apr 12 '21 12:04 Salakar

Oh, duh. Will check it out 🤦‍♂️

Ehesp avatar Apr 12 '21 12:04 Ehesp

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Dec 05 '22 19:12 github-actions[bot]