notifee
notifee copied to clipboard
invertase
fix(iOS): Allow the original delegate to handle non-Notifee notifications first
Issues
Fixes
- #925
- #984
Overview
For notifications received when the app is backgrounded or killed in iOS (through userNotificationCenter:didReceiveNotificationResponse:), the original delegate is not invoked for non-Notifee notifications. The existing code attempts to parse the unknown notification into a format Notifee understands before giving the original delegate a chance to handle it.
I've moved up original delegate so that it handles a non-Notifee notification first (if it exists). If there is no original delegate, then we fall back to parsing the unknown notification and allowing Notifee to handle it.
Testing
- Jest tests all pass
- iOS end-to-end tests all pass
- I have an app that handles both Iterable and Notifee notifications.
- Before this change: The Iterable notification was being handled by Notifee, resulting in a default behavior of launching to the app home screen.
- After this change: Notifee falls back to the original delegate when encountering the Iterable notification, resulting in handling the notification correctly & launching the app to the correct screen.
@mikehardy, Just wondering if we can get this in as this may be more common case and the bug prevents one listener from other
Tried this.
messaging().getInitialNotification() works now when iOS app is terminated.
Hello 👋, this PR has been opened for more than 2 months with no activity on it.
If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!
You have 15 days until this gets closed automatically
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
not stale
@mikehardy Is there a possibility to get this reviewed and merged? It would really help for projects that use libraries that depend on Notifee, but for projects where advanced notifee features are not directly required by the consumer (the developer), instead react-native-firebase is enough. This is exactly the use case I have and would greatly appreciate this change being merged. (same as in android, but that's a story for another PR)
If I correctly understand these changes, wouldn't the original delegate always get called instead of the notifee handler? E.g when I use react-native-firebase? Should there be an option to toggle that behaviour?
Hello 👋, this PR has been opened for more than 2 months with no activity on it.
If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!
You have 15 days until this gets closed automatically
I can confirm that this solves #913 as well.
I would love to see this merged soon!
Hello 👋, this PR has been opened for more than 2 months with no activity on it.
If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!
You have 15 days until this gets closed automatically
Thanks for fixing and merging it. Any idea when this will be included in an upcoming release?
@gotcha84 looks like this was merged, but has some linting issues https://github.com/invertase/notifee/actions/runs/9472210287/job/26097204168
@helenaford any reason aside from linting issues to not get another release out with this included?
Ok. @gotcha84 i did the cleanup
@helenaford it's clean now.
https://github.com/invertase/notifee/pull/1073
@helenaford @mikehardy is it possible to merge the fix #1073 provided by @markalanevans? Currently, the library is incompatible with the latest RN versions since it fails the TS check.
Hey there - @notifee/[email protected] is published just now with these changes --> https://github.com/invertase/notifee/releases/tag/%40notifee%2Freact-native%407.9.0
