melos icon indicating copy to clipboard operation
melos copied to clipboard

test: fix tests in Windows environment

Open jessicatarra opened this issue 1 year ago โ€ข 4 comments

Description

Hello Everyone ๐Ÿ‘‹. Some tests were failing when running in Windows environments, so this PR addresses this issue and offers a fix.

Fixes: #757

Type of Change

  • [ ] โœจ feat -- New feature (non-breaking change which adds functionality)
  • [x] ๐Ÿ› ๏ธ fix -- Bug fix (non-breaking change which fixes an issue)
  • [ ] โŒ ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] ๐Ÿงน refactor -- Code refactor
  • [ ] โœ… ci -- Build configuration change
  • [ ] ๐Ÿ“ docs -- Documentation
  • [ ] ๐Ÿ—‘๏ธ chore -- Chore

jessicatarra avatar Aug 19 '24 18:08 jessicatarra

To view this pull requests documentation preview, visit the following URL:

melos.invertase.dev/~751

Documentation is deployed and generated using docs.page.

docs-page[bot] avatar Aug 19 '24 18:08 docs-page[bot]

@spydon even though this fix addresses the issue, it's a very hacky solution and I'm still testing in order to figure out the root cause of the problem

jessicatarra avatar Aug 19 '24 18:08 jessicatarra

@spydon, It seems like the exit code when running in Windows environments is not reliable, and this causes issues when using some Melos commands.

jessicatarra avatar Aug 20 '24 03:08 jessicatarra

@spydon, It seems like the exit code when running in Windows environments is not reliable, and this causes issues when using some Melos commands.

Hmm, there must be some underlying issue for that...

spydon avatar Aug 20 '24 07:08 spydon

Closing this as stale.

spydon avatar Jan 10 '25 17:01 spydon